Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: connection reset by peer during "race" tests #17713

Closed
rsc opened this issue Nov 1, 2016 · 1 comment
Closed

net/http: connection reset by peer during "race" tests #17713

rsc opened this issue Nov 1, 2016 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8

Comments

@rsc
Copy link
Contributor

rsc commented Nov 1, 2016

From a recent all.bash on macOS Sierra:

--- FAIL: TestTimeoutHandlerRaceHeader (0.01s)
	serve_test.go:1943: Get http://127.0.0.1:49639: dial tcp 127.0.0.1:49639: getsockopt: connection reset by peer
--- FAIL: TestServerEmptyBodyRace_h2 (0.11s)
	serve_test.go:3685: Get https://127.0.0.1:49765: read tcp 127.0.0.1:49766->127.0.0.1:49765: read: connection reset by peer
	serve_test.go:3698: handler ran 19 times; want 20

I see stuff like this with some regularity. Not sure if Sierra changed something or the test is buggy or both.

/cc @bradfitz
@rsc rsc added this to the Go1.8 milestone Nov 1, 2016
@rsc rsc added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 7, 2016
@bradfitz
Copy link
Contributor

Same comment here as #17651 (comment)

I ran all these tests in a loop on Sierra (on my home iMac 5K) and can't reproduce.

Closing for now. Please reopen if you see any flake, though. I'm not content with any test being flaky.

@tombergan tombergan mentioned this issue Nov 2, 2017
Closed
@golang golang locked and limited conversation to collaborators Nov 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@bradfitz @rsc @gopherbot