New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: leaked C.CString in plugin_dlopen.go #17683

Closed

gonzalop opened this issue Oct 31, 2016 · 1 comment

Labels

Milestone

gonzalop commented Oct 31, 2016 •

edited

cRelName in https://github.com/golang/go/blob/master/src/plugin/plugin_dlopen.go#L46 is not freed if realpath fails:

cRelName := C.CString(name)
if C.realpath(cRelName, cPath) == nil {
    C.free(unsafe.Pointer(cRelName)) // <=== This line should be added to the code.
    return nil, errors.New("plugin.Open(" + name + "): realpath failed")
}
C.free(unsafe.Pointer(cRelName))

The text was updated successfully, but these errors were encountered:

gopherbot commented Oct 31, 2016

CL https://golang.org/cl/32438 mentions this issue.

rakyll changed the title ~~Leaked C.CString in plugin_dlopen.go~~ plugin: leaked C.CString in plugin_dlopen.go

rakyll added this to the Go1.8 milestone

gopherbot closed this as completed in

719b493

golang locked and limited conversation to collaborators

gopherbot added the FrozenDueToAge label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.