Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: IsolationLevel constants are spelled incorrectly #17682

Closed
kevinburke opened this issue Oct 31, 2016 · 2 comments
Closed

database/sql: IsolationLevel constants are spelled incorrectly #17682

kevinburke opened this issue Oct 31, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@kevinburke
Copy link
Contributor

kevinburke commented Oct 31, 2016 •
edited
Loading

Commit ce6aa2e added three constants which contain a misspelled word - LevelReadUncommited, LevelReadCommited, LevelWriteCommited should be LevelReadUncommitted, LevelReadCommitted, and LevelWriteCommitted respectively.

I'm happy to submit a patch but not sure if they have to stay as-is or break the compatibility promise. A search on github.com for "LevelReadUncommited" returns only two results, the golang/go result, and a fork. https://github.com/search?q=LevelReadUncommited&ref=simplesearch&type=Code&utf8=%E2%9C%93

http://www.dictionary.com/browse/committed
@minux
Copy link
Member

minux commented Oct 31, 2016 via email

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/32418 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@minux @kevinburke @gopherbot