Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: improve error message when unable to detect symlinked packages during go install #17662

Closed
krisnova opened this issue Oct 29, 2016 · 2 comments
Closed

cmd/go: improve error message when unable to detect symlinked packages during go install #17662

krisnova opened this issue Oct 29, 2016 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@krisnova
Copy link

V 1.6.2 Darwin/AMD64

filepath.Walk does not (and will not) respect traversing symlinks. (See #17451)

Can we improve the error message when a user attempts to run go install on a package that is a symlink? Right now the error message is "warning: %q matched no packages\n".

That does not offer the user insight into why the package did not build as expected.
@bradfitz bradfitz changed the title Improve error message when unable to detect symlinked packages during go install cmd/go: improve error message when unable to detect symlinked packages during go install Oct 29, 2016
@bradfitz bradfitz added this to the Go1.8Maybe milestone Oct 29, 2016
@bradfitz
Copy link
Contributor

Kinda documentation. But also code. For Go 1.8 if trivial.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 8, 2016
@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Nov 11, 2016
@gopherbot
Copy link

CL https://golang.org/cl/46425 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
5 participants
@bradfitz @rsc @quentinmit @gopherbot @krisnova