Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/arch/ppc64/ppc64spec: build fails on 386 #17635

Closed
bradfitz opened this issue Oct 27, 2016 · 6 comments
Closed

x/arch/ppc64/ppc64spec: build fails on 386 #17635

bradfitz opened this issue Oct 27, 2016 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

The x/arch subrepo is broken for 386:

freebsd-386-gce101 at 2f6557233c5a5c311547144c34b4045640ff9f71 building arch at fcea5eadff8971892040173c479da59c6f11436a

ok      golang.org/x/arch/arm/armasm    0.009s
?       golang.org/x/arch/arm/armmap    [no test files]
ok      golang.org/x/arch/ppc64/ppc64asm    0.005s
?       golang.org/x/arch/ppc64/ppc64map    [no test files]
# golang.org/x/arch/ppc64/ppc64spec
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:146: undefined: pdf.Outline
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:153: undefined: pdf.Outline
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:174: undefined: pdf.Page
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:271: undefined: pdf.Content
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:271: undefined: pdf.Text
../../gopath/src/golang.org/x/arch/ppc64/ppc64spec/spec.go:396: undefined: pdf.Rect

/cc @odeke-em
@bradfitz bradfitz added Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure. help wanted labels Oct 27, 2016
@bradfitz bradfitz added this to the Go1.8 milestone Oct 27, 2016
@odeke-em
Copy link
Member

Interestingly when I cross-compile it on my Mac, I don't get any problems
screen shot 2016-10-28 at 12 09 25 am

Perhaps we need to refresh the code on the builders with go get -u since the code that introduces rsc.io/pdf was added 16 days ago with commit golang/arch@21375ab

@bradfitz
Copy link
Contributor Author

The builders don't run go get -u. They live in a hermetic world and test exactly what's in the repo.

@odeke-em
Copy link
Member

Ah gotcha, I see that now they have vendored code that was last updated on July 15 2016 https://github.com/golang/arch/commits/master/vendor.

@odeke-em
Copy link
Member

Got it, mailed https://go-review.googlesource.com/32241.

@gopherbot
Copy link

CL https://golang.org/cl/32241 mentions this issue.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2016
@gopherbot
Copy link

CL https://golang.org/cl/33247 mentions this issue.

@golang golang locked and limited conversation to collaborators Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @quentinmit @odeke-em @gopherbot