You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Based on the commit message, support for concurrent calls to requestBody.Close.
What did you see instead?
A closed bool field that makes Close() idempotent but not goroutine safe.
Supporting concurrent Close() may not be worth the effort. I've been bitten by it once due to defers and timeouts but that was my fault and now context makes that stuff much simpler. The commit message could be clearer about what the closed bool is for though.
The text was updated successfully, but these errors were encountered:
rakyll
changed the title
golang/net/http2: clarifying concurrent Close on requestBody
x/net/http2: clarifying concurrent Close on requestBody
Oct 25, 2016
What version of Go are you using (
go version
)?go version go1.7.1 darwin/amd64
What operating system and processor architecture are you using (
go env
)?What did you do?
Read golang/net@40a0a18
What did you expect to see?
Based on the commit message, support for concurrent calls to requestBody.Close.
What did you see instead?
A closed bool field that makes Close() idempotent but not goroutine safe.
Supporting concurrent Close() may not be worth the effort. I've been bitten by it once due to defers and timeouts but that was my fault and now context makes that stuff much simpler. The commit message could be clearer about what the closed bool is for though.
The text was updated successfully, but these errors were encountered: