Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/gcexportdata: fails on Windows #17565

Closed
bradfitz opened this issue Oct 24, 2016 · 4 comments
Closed

x/tools/go/gcexportdata: fails on Windows #17565

bradfitz opened this issue Oct 24, 2016 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bradfitz
Copy link
Contributor

The dashboard is red for x/tools on Windows: see https://build.golang.org/ ....

https://build.golang.org/log/9b26b9bbccfc5cd7cf490b38423d8d8e196cffd2

--- FAIL: ExampleRead (0.00s)
got:
Package path:       fmt
Export data:        fmt.a
Package members:    [Errorf Formatter Fprint Fprintf Fprintln]...
Println type:       func(a ...interface{}) (n int, err error)
Println location:   $GOROOT\src\fmt\print.go:123:1
want:
Package path:       fmt
Export data:        fmt.a
Package members:    [Errorf Formatter Fprint Fprintf Fprintln]...
Println type:       func(a ...interface{}) (n int, err error)
Println location:   $GOROOT/src/fmt/print.go:123:1
--- FAIL: ExampleNewImporter (0.02s)
got:
const math.Pi untyped float = 3.14159 // $GOROOT\src\math\const.go:11:1
const TwoPi untyped float = 6.28319 // twopi.go:5:7
want:
const math.Pi untyped float = 3.14159 // $GOROOT/src/math/const.go:11:1
const TwoPi untyped float = 6.28319 // twopi.go:5:7
FAIL
FAIL    golang.org/x/tools/go/gcexportdata  0.067s
@bradfitz bradfitz added this to the Go1.8 milestone Oct 24, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 24, 2016
@griesemer
Copy link
Contributor

This is new code by @adonovan.

@griesemer griesemer removed their assignment Oct 25, 2016
@alandonovan
Copy link
Contributor

Sorry, I thought I'd fixed it with https://go-review.googlesource.com/c/31813/ but there's a second instance. Fix pending...

@gopherbot
Copy link

CL https://golang.org/cl/32034 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Oct 25, 2016
(The first was go-review.googlesource.com/c/31813)

Fixes issue golang/go#17565

Change-Id: I61c124e041af689913aedebdde654197c5526228
Reviewed-on: https://go-review.googlesource.com/32034
Reviewed-by: Robert Griesemer <gri@golang.org>
@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 8, 2016

Looks fixed.

@bradfitz bradfitz closed this as completed Dec 8, 2016
@golang golang locked and limited conversation to collaborators Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

5 participants