Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/poly1305: Sum declared in both sum_ref.go:37 and sum_arm.go for Go 1.6 #17512

Closed
chadmiller opened this issue Oct 19, 2016 · 2 comments
Closed

x/crypto/poly1305: Sum declared in both sum_ref.go:37 and sum_arm.go for Go 1.6 #17512

chadmiller opened this issue Oct 19, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@chadmiller
Copy link

What version of Go are you using (go version)?

1.6.2-0ubuntu5~16.04

What operating system and processor architecture are you using (go env)?

Ubuntu 16.04, armhf

What did you do?

Tried to build/install https://github.com/Yawning/obfs4 on an ARMHF machine.

go install ./obfs4.git/...
# golang.org/x/crypto/poly1305
golang.org/x/crypto/poly1305/sum_ref.go:37: Sum redeclared in this block
    previous declaration at golang.org/x/crypto/poly1305/sum_arm.go:16
Command '['/bin/sh', '/tmp/tmpy80swmr2', 'go', 'install', './obfs4.git/...']' returned non-zero exit status 2

Happens only for 32-bit arm. Not arm64, amd64, i386.
@bradfitz bradfitz added this to the Go1.8 milestone Oct 19, 2016
@bradfitz
Copy link
Contributor

@agl, this only affects Go 1.6. The +build constraints aren't quite right.

I'm tagging this Go1.8 because it needs to be done soon (red builders aren't useful to anybody), but it's not actually part of the release.

@bradfitz bradfitz changed the title Sum declared in both x/crypto/poly1305/sum_ref.go:37 and x/crypto/poly1305/sum_arm.go:16 x/crypto/poly1305: Sum declared in both sum_ref.go:37 and sum_arm.go for Go 1.6 Oct 19, 2016
@gopherbot
Copy link

CL https://golang.org/cl/31492 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 20, 2017
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@agl
poly1305: enable assembly for ARM in Go 1.6.
2a89beb 
5f31782 added build constraints to
disable assembly for Go 1.6 but didn't add the needed tags to the ARM
files. Also, it's not clear that was needed as the error given in
golang/go#17424 only complains about the chacha20poly1305 package.

This change reenables the assembly for Go 1.6 in the poly1305 package.
Tested with 1.6.3 and 1.5.4.

Fixes golang/go#17512.

Change-Id: I81b41f8810437ea327b415542402cd8ff5c8a390
Reviewed-on: https://go-review.googlesource.com/31492
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee added a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@c-expert-zigbee
poly1305: enable assembly for ARM in Go 1.6.
36a46d8 
5f31782 added build constraints to
disable assembly for Go 1.6 but didn't add the needed tags to the ARM
files. Also, it's not clear that was needed as the error given in
golang/go#17424 only complains about the chacha20poly1305 package.

This change reenables the assembly for Go 1.6 in the poly1305 package.
Tested with 1.6.3 and 1.5.4.

Fixes golang/go#17512.

Change-Id: I81b41f8810437ea327b415542402cd8ff5c8a390
Reviewed-on: https://go-review.googlesource.com/31492
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@rsc rsc unassigned agl Jun 23, 2022
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@agl
poly1305: enable assembly for ARM in Go 1.6.
515ba65 
a3505e7 added build constraints to
disable assembly for Go 1.6 but didn't add the needed tags to the ARM
files. Also, it's not clear that was needed as the error given in
golang/go#17424 only complains about the chacha20poly1305 package.

This change reenables the assembly for Go 1.6 in the poly1305 package.
Tested with 1.6.3 and 1.5.4.

Fixes golang/go#17512.

Change-Id: I81b41f8810437ea327b415542402cd8ff5c8a390
Reviewed-on: https://go-review.googlesource.com/31492
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@agl
poly1305: enable assembly for ARM in Go 1.6.
b76b413 
5f31782 added build constraints to
disable assembly for Go 1.6 but didn't add the needed tags to the ARM
files. Also, it's not clear that was needed as the error given in
golang/go#17424 only complains about the chacha20poly1305 package.

This change reenables the assembly for Go 1.6 in the poly1305 package.
Tested with 1.6.3 and 1.5.4.

Fixes golang/go#17512.

Change-Id: I81b41f8810437ea327b415542402cd8ff5c8a390
Reviewed-on: https://go-review.googlesource.com/31492
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @agl @chadmiller @gopherbot