Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: eliminate builtin.go bootstrapping problem #17508

Closed
mdempsky opened this issue Oct 18, 2016 · 2 comments
Closed

cmd/compile: eliminate builtin.go bootstrapping problem #17508

mdempsky opened this issue Oct 18, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@mdempsky
Copy link
Member

Regenerating builtin.go is tricky currently because it needs a working compiler that can generate export data in the same format as the new compiler can handle. We should replace it with something simpler.

I propose instead of generating export data for builtin/runtime.go, we just generate code/tables to directly construct the stub information. This can be done using just go/ast.
@mdempsky mdempsky self-assigned this Oct 18, 2016
@gopherbot
Copy link

CL https://golang.org/cl/31433 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 18, 2016
@mdempsky
cmd/compile: handle unsafe builtins like universal builtins
3f2cb49 
Reuse the same mechanisms for handling universal builtins like len to
handle unsafe.Sizeof, etc. Allows us to drop package unsafe's export
data, and simplifies some code.

Updates #17508.

Change-Id: I620e0617c24e57e8a2d7cccd0e2de34608779656
Reviewed-on: https://go-review.googlesource.com/31433
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot
Copy link

CL https://golang.org/cl/31493 mentions this issue.

@griesemer griesemer mentioned this issue Oct 20, 2016
Closed
@golang golang locked and limited conversation to collaborators Oct 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot