Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: playground internals article contains many broken references to code.google.com #17501

Closed
dgryski opened this issue Oct 18, 2016 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dgryski
Copy link
Contributor

dgryski commented Oct 18, 2016

The article https://blog.golang.org/playground has ~25 links to repositories and individual commits on code.google.com for various projects. These links are all dead.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 20, 2016
@quentinmit quentinmit changed the title blog: playground internals article contains many broken references to code.google.com website: playground internals article contains many broken references to code.google.com Oct 20, 2016
@quentinmit quentinmit added this to the Unreleased milestone Oct 20, 2016
@broady
Copy link
Member

broady commented Feb 3, 2017

This one's probably a bit more tricky, need to hunt down the relevant commits in the now defunct nacl tree.

If someone would like to help, I made a clone of the Mercurial repository, retaining the commit hashes. It might help to match them to CLs and/or git hashes.
https://bitbucket.org/broady/go-archive/

@bradfitz
Copy link
Contributor

bradfitz commented Feb 3, 2017

@broady, which Mercurial hashes (and in which original repo?) are you trying to map?

@broady
Copy link
Member

broady commented Feb 3, 2017

@bradfitz from the original code.google.com/p/go repo. No particular hashes for this article - since all the URLs refer to a fork of the repo. But I used this archive to map a bunch for some other articles:
https://golang.org/cl/36311/

The links in the playground article are completely broken and difficult to map, as they refer to @rsc's nacl fork of the go repo. It looks like Google Code forks weren't archived, so they're possibly lost forever.

Example URL from the playground article:
https://code.google.com/r/rsc-go13nacl/source/browse/src/pkg/runtime/sys_nacl_amd64p32.s?r=1f01be1a1dc2#54

No commit ID exists:
https://bitbucket.org/broady/go-archive/commits/1f01be1a1dc2

So they'd require some more manual work (and maybe removing/changing line numbers in the URL hash).

@rsc
Copy link
Contributor

rsc commented Feb 3, 2017

Re

(This special tool chain will be merged into the core for Go 1.3. To learn more, read the design document. If you want to play with NaCl before then, you can check out a fork that has all the changes.)

Let's just rewrite to

(This special tool chain was merged into Go 1.3. To learn more, read the design document.)

@gopherbot
Copy link

CL https://golang.org/cl/36313 mentions this issue.

@broady
Copy link
Member

broady commented Feb 3, 2017

Well, I dug up an archive of the rsc-go13nacl fork. Hosted here now:
https://bitbucket.org/broady/rsc-go13nacl-archive/

@golang golang locked and limited conversation to collaborators Feb 16, 2018
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
Fixes golang/go#17501.

Change-Id: Ib3ef8186e161a89150e5ad400cae0ad15bffa701
Reviewed-on: https://go-review.googlesource.com/36313
Reviewed-by: Russ Cox <rsc@golang.org>
X-Blog-Commit: 07e6e79f615b84719cd5651ae3ceab5d0c56d384
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Fixes golang/go#17501.

Change-Id: Ib3ef8186e161a89150e5ad400cae0ad15bffa701
Reviewed-on: https://go-review.googlesource.com/36313
Reviewed-by: Russ Cox <rsc@golang.org>
X-Blog-Commit: 07e6e79f615b84719cd5651ae3ceab5d0c56d384
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

6 participants