-
Notifications
You must be signed in to change notification settings - Fork 18k
x/tools/refactor/rename: emacs package broken #17468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
here's a script you can run to set up the problem reproducibly with a stock go 1.7.1: #!/bin/bash
#
# script to test go-rename all by itself from scratch
#
# i ran it on the standard "Amazon Linux AMI 2016.09.0 (HVM), SSD Volume Type - ami-c481fad3", but should work similarly on any linux box
#
cd
yum -y install tmux emacs git hg libtool gcc patch glibc-static
wget https://storage.googleapis.com/golang/go1.7.1.linux-amd64.tar.gz
tar xf go1.7.1.linux-amd64.tar.gz
export GOROOT=`pwd`/go
export GOPATH=`pwd`
export PATH=$GOPATH/bin:$GOROOT/bin:$PATH
go get golang.org/x/tools/cmd/gorename
git clone https://github.com/dominikh/go-mode.el.git
mkdir go/misc/emacs
find . -type f -name "*.el" -exec cp \{} ~/go/misc/emacs \;
cat > ~/.emacs <<EOF
(add-to-list 'load-path "~/go/misc/emacs/" t)
(require 'go-rename)
EOF
cat > ~/test.go <<EOF
package main
import "fmt"
func main() {
var x string
x = "abc"
fmt.Println(x)
}
EOF after running this script (above), edit |
CL https://golang.org/cl/31471 mentions this issue. |
dominikh
added a commit
to dominikh/go-mode.el
that referenced
this issue
Oct 19, 2016
go-rename.el used the cl list* macro without requiring cl. This only worked for people who required it for other code. go-guru.el, before its removal from the tree, changed from cl to cl-lib, indirectly breaking go-rename.el for some users. Switch to using cl-list* and require cl-lib. Fixes golang/go#17468 Change-Id: I70f2052b9fd3d1a8671794d9a3954be218026af2 Reviewed-on: https://go-review.googlesource.com/31471 Reviewed-by: Alan Donovan <adonovan@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What did you do?
built and installed go-rename and its emacs mode following
https://github.com/golang/tools/blob/master/refactor/rename/go-rename.el as i have usually done these last several months.
What did you expect to see?
after running
go-rename
within emacs mode like i've usually done, successfully renaming something in the source code.What did you see instead?
no renaming occurred, and the following error message in emacs debug window, which is new:
([elided] in the above means i simply removed some irrelevant private information)
Does this issue reproduce with the latest release (go1.7.1)?
n/a
System details
The text was updated successfully, but these errors were encountered: