Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestRetryIdempotentRequestsOnError test flake #17438

Closed
bradfitz opened this issue Oct 13, 2016 · 1 comment
Closed

net/http: TestRetryIdempotentRequestsOnError test flake #17438

bradfitz opened this issue Oct 13, 2016 · 1 comment
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8Maybe

Comments

@bradfitz
Copy link
Contributor

https://build.golang.org/log/93e89eec82df9a7e28005688c2e179f7c9418896

--- FAIL: TestRetryIdempotentRequestsOnError (0.19s)
    transport_test.go:2588: did not trigger any retries
FAIL
FAIL    net/http    18.135s
@bradfitz bradfitz added Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure. help wanted labels Oct 13, 2016
@bradfitz bradfitz added this to the Go1.8Maybe milestone Oct 13, 2016
@quentinmit quentinmit added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 21, 2016
@bradfitz
Copy link
Contributor Author

I can no longer reproduce. I might've fixed this by accident as part of test parallelization & test deflaking.

@golang golang locked and limited conversation to collaborators Nov 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
3 participants
@bradfitz @quentinmit @gopherbot