Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: Spamming error #17414

Closed
bep opened this issue Oct 12, 2016 · 2 comments
Closed

html/template: Spamming error #17414

bep opened this issue Oct 12, 2016 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@bep
Copy link
Contributor

bep commented Oct 12, 2016

See

go/src/html/template/template.go

Line 83 in 964639c

return fmt.Errorf("template: %q is an incomplete or empty template%s", t.Name(), t.DefinedTemplates())

  • This error isn't very useful if you have 100s or 1000s of templates
  • If I really need that debug info, I will call DefinedTemplates myself
  • One could even argue that this is a DDoS "invitation" in certain situations

gohugoio/hugo#2343
@quentinmit quentinmit added this to the Go1.8Maybe milestone Oct 12, 2016
@quentinmit quentinmit added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 12, 2016
@rsc rsc self-assigned this Oct 19, 2016
@rsc rsc modified the milestones: Go1.8, Go1.8Maybe Oct 19, 2016
@rsc
Copy link
Contributor

rsc commented Oct 26, 2016

Going to try sending a CL and see what people think.

@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Oct 26, 2016
@gopherbot
Copy link

CL https://golang.org/cl/32116 mentions this issue.

@bradleypeabody bradleypeabody mentioned this issue Jan 10, 2017
Merged
@golang golang locked and limited conversation to collaborators Oct 28, 2017
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@rsc @quentinmit @bep @gopherbot