New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/exp/shiny: OSX Appkit deprecations on OSX 10.12 (Sierra) #17413
Comments
@nigeltao Let me know how i can contribute to this repo. Also the widgets are coming along ok ! |
@joeblew99 Take a look at https://golang.org/doc/contribute.html to learn how to use Gerrit to contribute code. |
mhhh. Cant i just sign the CLA and send a PR :) ? |
We use Gerrit for all code review (and CLA enforcement), not PRs. Sorry. |
Just too busy on the current commercial project right now to do this. Instead, i inline the the fix: You can easily drop this in and see the differences with git yourself..
|
CL https://golang.org/cl/31539 mentions this issue. |
…ted since OSX 10.12 Reason for revert: constants not available on older OS X releases Original issue's description: > shiny/driver: repace style mask and event constants deprecated since OSX 10.12 > > Fixes golang/go#17413. > > Change-Id: I4cc8a980fc1d6a45ceef48b282baa7a94663ae10 > Reviewed-on: https://go-review.googlesource.com/31539 > Reviewed-by: David Crawshaw <crawshaw@golang.org> > Change-Id: I35bd4301ebf63689d6b7bb49a29b9ef85657ba1e Reviewed-on: https://go-review.googlesource.com/31613 Reviewed-by: David Crawshaw <crawshaw@golang.org>
CL https://golang.org/cl/31543 mentions this issue. |
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?What operating system and processor architecture are you using (
go env
)?What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
What did you expect to see?
no errors...
What did you see instead?
The text was updated successfully, but these errors were encountered: