Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Add missing tests for parsePostForm #17368

Closed
asticode opened this issue Oct 6, 2016 · 2 comments
Closed

net/http: Add missing tests for parsePostForm #17368

asticode opened this issue Oct 6, 2016 · 2 comments
Labels
FrozenDueToAge help wanted Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@asticode
Copy link
Contributor

asticode commented Oct 6, 2016

@bradfitz since #14655 has been reverted I think that would be wise to patch tests as well in TestPostQuery and TestPatchQuery with use cases mentionned in https://go-review.googlesource.com/#/c/30454/ and https://go-review.googlesource.com/#/c/30470/ so that those cases are not forgotten in the future. What do you think ?

@bradfitz
Copy link
Contributor

bradfitz commented Oct 6, 2016

Sounds good.

@bradfitz bradfitz added this to the Unreleased milestone Oct 6, 2016
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 6, 2016
@bradfitz bradfitz modified the milestones: Unplanned, Unreleased Oct 6, 2016
@bradfitz bradfitz added Suggested Issues that may be good for new contributors looking for work to do. help wanted labels Oct 6, 2016
@gopherbot
Copy link

CL https://golang.org/cl/30555 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge help wanted Suggested Issues that may be good for new contributors looking for work to do. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants