-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: set up WSL Windows Subsystem For Linux (Linux-on-Windows) builder #17365
Comments
I'd prefer a Windows 10 builder (or "Windows Server 2016") first, which we don't even have. But it's not offered on GCE yet: https://cloud.google.com/compute/docs/instances/windows/#windows_server (only 2008 and 2012). So unless we want to run builders on Azure or our Mac VMWare cluster, this is blocked for now. |
@bradfitz |
However, more relevantly for this bug, Windows Server 2016 does not support Linux on Windows yet. |
I ran |
"We" don't have a ways to go. We target Linux. |
Yes, what we do is modify the stack to look like a call to Looking at your log that is at least partially working. I see that the signal handler is indeed returning to |
@bradfitz: Agreed, this is mostly Microsoft's problem, not ours. I think we should have the goal of Go running on Linux-on-Windows, and we should invest (some) time in debugging problems with that configuration. If the problem is caused by our code, we should change our code. If the problem is a bug in the Windows kernel, we should file a bug upstream and not work around it in Go. Likely most/all of the test failures are kernel bugs, but we should at least do the debugging to find out what the kernel bugs are so we can file issues upstream. |
I think by definition is can not be a problem with our code, ever. Microsoft has committed to emulating Linux, which isn't a spec. We're targeting Linux, not a spec. If our Linux builders are passing, it's not our fault. So the onus is on Microsoft to forever play catch-up and react to Linux differences. But I agree we can help report bugs to Microsoft, and it would be nice to see it work. |
@bradfitz Actually it's Ubuntu on Windows by Canonical. Ubuntu on Windows – The Ubuntu Userspace for Windows Developers Howdy, Windows! A Six-part Series about Ubuntu-on-Windows for Linux.com |
@peterGo, I don't care about their marketing department. They implement the Linux system calls. There's nothing specific to Ubuntu here other than marketing. |
@bradfitz My understanding is that Linux-on-Windows is not yet available for Windows Server 2016, because it's "not intended for server use". |
Hah. Interesting. |
I wonder if there's a workaround to enable the feature? I'm not sure if we can run desktop SKUs on GCP. |
And now that's going to change: WSL on Windows Server |
Hah... I asked @bitcrazed about this at OSCON on Wednesday about an hour before this was announced. Props to Rich for managing to not spill the beans. |
@johnsonj Hi, any news? |
Thanks for the ping @mengzhuo ! I'm unassigning as I am not actively working on this. |
@mengzhuo, see http://golang.org/wiki/DashboardBuilders#how-to-set-up-a-builder for setup instructions; you'll need to coordinate with @golang/release to get a builder key. |
@bcmills I've send the request on golang-dev. |
@mengzhuo I've responded to you via email with the host and private builder key. A list of next steps are included in the email as well. |
Change https://golang.org/cl/272266 mentions this issue: |
Change https://golang.org/cl/272267 mentions this issue: |
@cagedmantis Hi, I've uploaded 2 CLs for adding this builder. The builder is now runing the build service and ready to go :) |
Updates golang/go#17365 Change-Id: I90b9c1c8f82ae9164deacea36ff5dafd008eef03 Reviewed-on: https://go-review.googlesource.com/c/build/+/272266 Trust: Meng Zhuo <mzh@golangcn.org> Run-TryBot: Meng Zhuo <mzh@golangcn.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
I've submitted builder to repo, however I found the binary from googlesource still end up like the old one. Is there any step I'm missing?
|
Ping |
@golang/release, is this just waiting on a |
We can plan for a deployment of the coordinator. The buildlet should connect (and maintain a connection to the coordinator without a deployment though). |
@mengzhuo The coordinator has been deployed. That builder should be up and running. |
Thanks! It's up and testing CL now! |
I have talked with @mengzhuo add another new WSL builder in |
Change https://golang.org/cl/278874 mentions this issue: |
For golang/go#17365 Change-Id: Icf776550e3f17d86bf0f74d5598912fe1a18cb50 Reviewed-on: https://go-review.googlesource.com/c/build/+/278874 Run-TryBot: Baokun Lee <bk@golangcn.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Meng Zhuo <mzh@golangcn.org> Reviewed-by: Carlos Amedee <carlos@golang.org> Trust: Bryan C. Mills <bcmills@google.com>
The two builders for WSL are up now. |
Update golang/go#17365 Change-Id: Iae9cce9b356790cb643f2f0a7ba637f90f185ebd Reviewed-on: https://go-review.googlesource.com/c/build/+/272267 Trust: Meng Zhuo <mzh@golangcn.org> Run-TryBot: Meng Zhuo <mzh@golangcn.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Even if it's not a first-class port, it's useful to know if/how it's broken.
The text was updated successfully, but these errors were encountered: