Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: sliceopt.go test failure on linux/ppc64 (BE) #17362

Closed
bradfitz opened this issue Oct 6, 2016 · 3 comments
Closed

cmd/compile: sliceopt.go test failure on linux/ppc64 (BE) #17362

bradfitz opened this issue Oct 6, 2016 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Oct 6, 2016

In addition to #17361, the only other error on linux/ppc64 (BE) is this:

##### ../test
# go run run.go -- sliceopt.go

sliceopt.go:13: missing error "append: len-only update"
sliceopt.go:18: missing error "append: full update"
sliceopt.go:22: missing error "append: len-only update"
sliceopt.go:27: missing error "slice: omit check for 2nd index"
sliceopt.go:30: missing error "slice: reuse 1st index"
sliceopt.go:30: missing error "slice: omit check for 1st index"
sliceopt.go:30: missing error "slice: result len == 0"
sliceopt.go:31: missing error "slice: reuse 2nd index"
sliceopt.go:31: missing error "slice: omit check for 2nd index"
sliceopt.go:31: missing error "slice: result cap == result len"
sliceopt.go:32: missing error "slice: omit check for 3rd index"
sliceopt.go:33: missing error "slice: omit check for 2nd index"
sliceopt.go:34: missing error "slice: omit check for 1st index"
sliceopt.go:34: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:36: missing error "slice: omit check for 1st index"
sliceopt.go:36: missing error "slice: result len == 6"
sliceopt.go:37: missing error "slice: omit check for 1st index"
sliceopt.go:37: missing error "slice: result len == 0"
sliceopt.go:38: missing error "slice: omit check for 1st index"
sliceopt.go:38: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:39: missing error "slice: result cap == 6"
sliceopt.go:40: missing error "slice: reuse 1st index"
sliceopt.go:40: missing error "slice: result cap == 0"
sliceopt.go:40: missing error "slice: skip base adjustment for cap == 0"
sliceopt.go:42: missing error "slice: omit check for 1st index"
sliceopt.go:42: missing error "slice: result cap not computed"
sliceopt.go:42: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:42: missing error "slice: len-only update"
sliceopt.go:43: missing error "slice: omit check for 1st index"
sliceopt.go:43: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:43: missing error "slice: len/cap-only update"
sliceopt.go:49: missing error "slice: omit check for 2nd index"
sliceopt.go:51: missing error "slice: reuse 1st index"
sliceopt.go:51: missing error "slice: omit check for 1st index"
sliceopt.go:51: missing error "slice: result len == 0"
sliceopt.go:51: missing error "slice: skip base adjustment for string len == 0"
sliceopt.go:53: missing error "slice: omit check for 1st index"
sliceopt.go:53: missing error "slice: result len == 6"
sliceopt.go:54: missing error "slice: omit check for 1st index"
sliceopt.go:54: missing error "slice: result len == 0"
sliceopt.go:54: missing error "slice: skip base adjustment for string len == 0"
sliceopt.go:55: missing error "slice: omit check for 1st index"
sliceopt.go:55: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:57: missing error "slice: omit check for 1st index"
sliceopt.go:57: missing error "slice: skip base adjustment for 1st index 0"
sliceopt.go:57: missing error "slice: len-only update"

FAIL    sliceopt.go 0.176s

/cc @dr2chase @mdempsky
@bradfitz bradfitz added this to the Go1.8 milestone Oct 6, 2016
@randall77
Copy link
Contributor

I think we can just delete sliceopt.go. It only works for the legacy compiler.

@bradfitz
Copy link
Contributor Author

bradfitz commented Oct 6, 2016

SGTM

@gopherbot
Copy link

CL https://golang.org/cl/30593 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@bradfitz @dr2chase @randall77 @gopherbot