Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sync: move internal/singleflight to x/sync #17338

Closed
SchumacherFM opened this issue Oct 4, 2016 · 4 comments
Closed

x/sync: move internal/singleflight to x/sync #17338

SchumacherFM opened this issue Oct 4, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@SchumacherFM
Copy link
Contributor

I would like to ask if it's possible to move package internal/singleflight to sync/singleflight for Go1.8?

I've searched the issues and there is already a proposal to move internal/singleflight into x/sync => #13058 but it never happend. I would love to see it in sync/singleflight instead of x/sync. I'm using singleflight nowadays as a copy in my repos like others also copied it. If OK, I can send a CL on Gerrit for the move to sync/singleflight.

What version of Go are you using (go version)?

go version devel +79db162 Fri Sep 30 05:15:19 2016 +0000 darwin/amd64
@bradfitz
Copy link
Contributor

bradfitz commented Oct 4, 2016

Yeah, I still want to see this happen.

@bradfitz bradfitz changed the title Proposal: Move internal/singleflight to sync or x/sync x/sync: move internal/singleflight to x/sync Oct 4, 2016
@bradfitz bradfitz added this to the Unplanned milestone Oct 4, 2016
@bradfitz
Copy link
Contributor

bradfitz commented Oct 4, 2016

It also exists at https://godoc.org/go4.org/syncutil/singleflight FWIW. But in its original form before the version in internal/singleflight grew a return value.

@gopherbot
Copy link

CL https://golang.org/cl/30292 mentions this issue.

gopherbot pushed a commit to golang/sync that referenced this issue Oct 4, 2016
@mdlayher @bradfitz
singleflight: copy from internal/singleflight in standard library
1ae7c7b 
Updates golang/go#17338

Change-Id: Icf1972cdec0bbc9b3142141d9e706c07f312efc0
Reviewed-on: https://go-review.googlesource.com/30292
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ALTree
Copy link
Member

ALTree commented Jul 8, 2019

This was done in https://go-review.googlesource.com/c/sync/+/30292/, so I'm closing here.

@ALTree ALTree closed this as completed Jul 8, 2019
@golang golang locked and limited conversation to collaborators Jul 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@bradfitz @SchumacherFM @ALTree @gopherbot