Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: improve PPC64.rules for const shifts #17336

Closed
laboger opened this issue Oct 4, 2016 · 1 comment
Closed

cmd/compile: improve PPC64.rules for const shifts #17336

laboger opened this issue Oct 4, 2016 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@laboger
Copy link
Contributor

laboger commented Oct 4, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version devel +fa49c39 Tue Oct 4 17:22:14 2016 +0000 linux/ppc64le

What operating system and processor architecture are you using (go env)?

Ubuntu 16.04 ppc64le

What did you do?

Looked at generated code in areas where performance could be improved.

What did you expect to see?

No code sequences to generate carry if the shift count is constant.

What did you see instead?

Code sequences like this
12a24: 0d 00 a0 38 li r5,13
12a28: c0 ff e5 33 addic r31,r5,-64
12a2c: d4 01 c0 7c addme r6,r0
12a30: 38 33 a5 7c orc r5,r5,r6
12a34: 36 2c 84 7c srd r4,r4,r5

Changes to PPC64.rules can improve this.

@gopherbot
Copy link

CL https://golang.org/cl/30310 mentions this issue.

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 4, 2016
@quentinmit quentinmit added this to the Go1.8 milestone Oct 4, 2016
@golang golang locked and limited conversation to collaborators Oct 5, 2017
@rsc rsc unassigned laboger Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants