Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: unexpected character in for clause causes misleading error #17328

Closed
0xmohit opened this issue Oct 3, 2016 · 3 comments
Closed

cmd/compile: unexpected character in for clause causes misleading error #17328

0xmohit opened this issue Oct 3, 2016 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.9

Comments

@0xmohit
Copy link
Contributor

0xmohit commented Oct 3, 2016

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build433231288=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

https://play.golang.org/p/nALNrCVtmz

What did you expect to see?

Something suggesting that ) was unexpected.

Using go 1.5.3, one would see:

# command-line-arguments
./t.go:5: syntax error: unexpected ), expecting {

What did you see instead?

# command-line-arguments
./t.go:5: syntax error: missing { after for clause

The current error isn't as helpful as it was.
@griesemer griesemer added this to the Go1.8Maybe milestone Oct 3, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@rsc
Copy link
Contributor

rsc commented Oct 20, 2016

It does seem like an error worth improving.

@rsc rsc modified the milestones: Go1.9, Go1.8Maybe Oct 20, 2016
@gopherbot
Copy link

CL https://golang.org/cl/36636 mentions this issue.

gopherbot pushed a commit that referenced this issue Feb 9, 2017
@griesemer
cmd/compile/internal/syntax: differentiate between ';' and '\n' in sy…
9799622 
…ntax errors

Towards better syntax error messages: With this change, the parser knows whether
a semicolon was an actual ';' in the source, or whether it was an automatically
inserted semicolon as result of a '\n' or EOF. Using this information in error
messages makes them more understandable.

For #17328.

Change-Id: I8cd9accee8681b62569d0ecef922d38682b401eb
Reviewed-on: https://go-review.googlesource.com/36636
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@gopherbot
Copy link

CL https://golang.org/cl/36637 mentions this issue.

@ALTree ALTree mentioned this issue Mar 7, 2017
Closed
@golang golang locked and limited conversation to collaborators Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
5 participants
@rsc @quentinmit @0xmohit @griesemer @gopherbot