Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: add check for Context.WithValue(_, string, _) #17293

Closed
bradfitz opened this issue Sep 30, 2016 · 6 comments
Closed

cmd/vet: add check for Context.WithValue(_, string, _) #17293

bradfitz opened this issue Sep 30, 2016 · 6 comments
Labels
FrozenDueToAge help wanted
Milestone
Go1.8

Comments

@bradfitz
Copy link
Contributor

Using a context.Context Value key of type string is a terrible idea and walks into the minefield of a global namespace. We should've outlawed it from day 1.

All context value keys should be made from user-defined types.

Also disallow int, bool, etc. But string is what I usually see.
@bradfitz bradfitz added this to the Go1.8 milestone Sep 30, 2016
@mdlayher
Copy link
Member

I'd be happy to give this a try.

@bradfitz
Copy link
Contributor Author

Thanks.

@bradfitz bradfitz reopened this Sep 30, 2016
@mdlayher
Copy link
Member

Submitted an initial CL here: https://go-review.googlesource.com/c/30084/.

I suspect there's probably more I can do, but I would appreciate some review before I pursue this issue further.

@robpike
Copy link
Contributor

robpike commented Sep 30, 2016

This is not a correctness issue and so should not be fixed in vet. It's a better candidate for lint.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/30084 mentions this issue.

This was referenced Sep 30, 2016
Closed
Closed
@dsnet
Copy link
Member

dsnet commented Oct 1, 2016

Merged as golang/lint@c6242af

@dsnet dsnet closed this as completed Oct 1, 2016
@endophage endophage mentioned this issue Oct 3, 2016
Merged
@asymmetric asymmetric mentioned this issue Oct 13, 2016
Merged
@bradfitz bradfitz mentioned this issue Nov 5, 2016
Closed
@nizsheanez nizsheanez mentioned this issue Nov 7, 2016
Closed
@willnewrelic willnewrelic mentioned this issue Jan 12, 2017
Closed
@golang golang locked and limited conversation to collaborators Oct 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
5 participants
@bradfitz @mdlayher @robpike @dsnet @gopherbot