Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/importer: confusing error when reading wrong kind of file #17281

Closed
alandonovan opened this issue Sep 29, 2016 · 2 comments
Closed

go/importer: confusing error when reading wrong kind of file #17281

alandonovan opened this issue Sep 29, 2016 · 2 comments
Milestone

Comments

@alandonovan
Copy link
Contributor

go/internal/gcimporter.FindExportData returns some errors directly from the underlying bufio.Reader, and these may be confusing to the caller. For example, we recently switched from using combined .a files to split .x/.a files for export data and object code. Tools that tried to load export data from a new .a file would seek beyond the end of the file in r.ReadSlice('\n'), which returned "buffer full".

FindExportData needs to prepend additional context such as "can't find export data: %v".

@griesemer griesemer added this to the Go1.8 milestone Sep 29, 2016
@gopherbot
Copy link

CL https://golang.org/cl/30473 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/30591 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Oct 6, 2016
…d lib

For golang/go#17281.

Change-Id: I7bed233368939719672eb331cca1d6aef01e807d
Reviewed-on: https://go-review.googlesource.com/30591
Reviewed-by: Alan Donovan <adonovan@google.com>
@golang golang locked and limited conversation to collaborators Oct 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants