time: TestLoadFixed failure #17276

ALTree · 2016-09-29T10:13:25Z

What version of Go are you using (`go version`)?

$ gotip version
go version devel +847bc6d Thu Sep 29 10:56:03 2016 +0200 linux/amd64
$ uname -a
Linux [...] 4.6.0-1-amd64 #1 SMP Debian 4.6.4-1 (2016-07-18) x86_64 GNU/Linux

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/[...]/gocode"
GORACE=""
GOROOT="/home/[...]/go"
GOTOOLDIR="/home/[...]/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build162033413=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

$ cd src/time
$ gotip test -run=TestLoadFixed

What did you see?

--- FAIL: TestLoadFixed (0.00s)
    time_test.go:947: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
exit status 1
FAIL    time    0.003s

The text was updated successfully, but these errors were encountered:

ALTree · 2016-09-29T11:45:02Z

A new version of tzdata, (tzdata-2016g), was released yesterday. From the changelog:

Several zones in Antarctica and the former Soviet Union, along
with zones intended for ships at sea that cannot use POSIX TZ
strings, now use numeric time zone abbreviations instead of
invented or obsolete alphanumeric abbreviations. The affected
zones are [...] Etc/GMT+1 [...]

Etc/GMT+1 is exactly the zone parsed in the failing test.

ALTree · 2016-09-29T11:57:45Z

Cooking up a patch.

ALTree · 2016-09-29T13:31:32Z

https://go-review.googlesource.com/#/c/29995

lfam · 2016-10-21T20:30:18Z

Applying the fix in c5434f2 to Go 1.4.3 (which can be used as a Go bootstrap compiler) does not work. It fails like this:

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
go tool dist: missing file /tmp/guix-build-go-1.4.3.drv-0/go/include/fmt.h

Any advice?

ianlancetaylor · 2016-10-21T20:48:48Z

This issue is closed and the bug you are reporting is not related to it. Please ask on a forum instead; see https://golang.org/wiki/Questions . Thanks.

banditsmile · 2016-10-22T17:07:46Z

use go1.4.3 binary package on ubuntu16.04 to build go1.7.3 still face this time package failed problem

ianlancetaylor · 2016-10-22T17:42:57Z

@banditsmile This issue is closed. It is not expected to be fixed in 1.4.3 or 1.7.3. If you want to make a case to backport the change to an older release, please open a new issue. Thanks.

Fixes golang#17276 Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4 Reviewed-on: https://go-review.googlesource.com/29995 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot · 2016-11-16T16:35:11Z

CL https://golang.org/cl/33308 mentions this issue.

Fixes golang#17276 Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4 Reviewed-on: https://go-review.googlesource.com/29995 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gdsotirov · 2016-12-02T07:48:35Z

The fix from c5434f2 is still not included in just released 1.7.4 and I cannot understand why. I have to manually apply the patch.

minux · 2016-12-02T08:03:50Z

Go 1.7.4 is a security-fix only release. And as this is a test-only change, it doesn't meet the requirement to be included in a minor release anyway.

ALTree · 2016-12-02T08:31:44Z

To be fair, the last time this happened the patch was actually cherry-picked in the following minor release.

See: milestone 1.3.3, the issue #8814 was fixes on tip (to be 1.4), but the patch was also included in 1.3.3.

tzdata test failures are harmless, but also pretty annoying because as soon as the major OSes receive the updated timezones data, all.bash will always fail on all architectures and on all systems, for all users.

minux · 2016-12-02T08:43:31Z

I think Go 1.3 predates the current release guidelines for minor releases. Please see https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance "A minor release is issued to address one or more critical problem for which there is no workaround (typically related to stability or security)." For this case, obviously the code for package time still works, so people doesn't even need a workaround.

ALTree · 2016-12-02T08:46:38Z

Ah, thanks. This is the part I missed:

The only code changes included in the release are the fixes for the specific critical problems

I was convinced it was something like "issued for serious problems, but then it's fine to cherry-pick other small stuff".

gdsotirov · 2016-12-02T09:37:50Z

@minux I haven't omitted the fact that 1.7.4 is a minor security release (there were clear announcements), but still I think cherry picking some other small changes like c5434f2 is worth it. Otherwise, packages like me would have to apply patches as normally most Linux distributions moved tzdata to newer than 2016g and thus it is annoying as @ALTree wrote. Anyway, we'll all have to wait for 1.7.5, 1.8 or whatever else release that includes c5434f2 when it's fully tested (I confirm it's well working on Slackware 14.2).

minux · 2016-12-02T10:03:29Z

If we have set the release guideline formally, then we need to stick to it. Let me quote from https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance again, with emphasis mine: "A minor release is issued to address one or more critical problem for which there is no workaround (typically related to stability or security). The only code changes included in the release are the fixes for the specific critical problems. Important documentation-only changes may also be included as well, but **nothing** more." The fix for this issue won't be included in any Go 1.7.x minor releases, and will be include Go 1.8 and above. I hope this is clear.

gdsotirov · 2016-12-02T10:49:37Z

@minux By no way I'm questioning Go's release cycle, but to me it appears too harsh if such small but useful fixes like c5434f2, which help keep Go aligned with the OS updates, are dropped completely from minor releases. And as a distribution packager I'd like to ask what is my workaround for the the time test failure then? I either have to suppress tests completely or I have to manage and apply patches, which as I already wrote is annoying especially for software under active development. Again, I accept Go members' position, but still I'd like express my dissatisfaction. Hopefully, Go 1.8 should be released in a month or so according to the beta1 announcement.

bradfitz · 2016-12-02T16:10:15Z

@gdsotirov, yeah, that's a bit unfortunate. I filed #18163.

gopherbot · 2016-12-06T21:40:07Z

CL https://golang.org/cl/34050 mentions this issue.

See: golang/go#17276 Granted, gvm doesn't normally run the tests, but I like to run them to ensure a build is healthy: $ gvm install <some-version> $ gvm use <some-version> $ go tool dist test -no-rebuild (Hey, maybe this test step could become a future `gvm install` option?) Also per golang/go#18163, test fixes may eventually be permitted for security point releases, at which point patches like these can possibly go away (since the fix would then be to use a later point release on affected platforms).

gopherbot · 2017-01-24T21:15:21Z

CL https://golang.org/cl/35635 mentions this issue.

Backport of the fix to #17276 for Go 1.7. Change-Id: Ifc1a8e2a81d4e543dbef04566985618884a8c0e0 Reviewed-on: https://go-review.googlesource.com/35635 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com> Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>

Fixes golang#17276 Change-Id: I0188cf9bc5fdb48c71ad929cc54206d03e0b96e4 Reviewed-on: https://go-review.googlesource.com/29995 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>

gopherbot closed this as completed in c5434f2 Sep 29, 2016

dgryski mentioned this issue Oct 19, 2016

Failing test in time package #17519

Closed

This was referenced Oct 21, 2016

time: TestLoadFixed failure #17545

Closed

net/http: test failure of TestServeContent on Guix #17535

Closed

bradfitz mentioned this issue Oct 23, 2016

build: bootstrapping Go 1.n on macOS Sierra from source #16352

Closed

msackman mentioned this issue Nov 5, 2016

TestLoadFixed (time_test.go:943) fails in compilation #17808

Closed

ALTree mentioned this issue Nov 9, 2016

test failed while building go on debian 8(debian jessie) #17864

Closed

bradfitz mentioned this issue Nov 27, 2016

time: TestLoadFixed fails on 1.7.3 source build #18064

Closed

bradfitz mentioned this issue Dec 2, 2016

doc: allow test-only changes in security point releases #18163

Closed

bradfitz mentioned this issue Dec 3, 2016

Failing to compile Go 1.7.4 on macOS #18188

Closed

ALTree mentioned this issue Jan 2, 2017

Unable to test go 1.6.4 with 1.6.3 on Mageia 5 (trying to package it) #18491

Closed

josharian mentioned this issue Jan 25, 2017

time, cmd/compile: backport fixes to 1.7.5 #18787

Closed

golang locked and limited conversation to collaborators Jan 24, 2018

gopherbot added the FrozenDueToAge label Jan 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

time: TestLoadFixed failure #17276

time: TestLoadFixed failure #17276

ALTree commented Sep 29, 2016 •

edited

ALTree commented Sep 29, 2016 •

edited

ALTree commented Sep 29, 2016

ALTree commented Sep 29, 2016

lfam commented Oct 21, 2016

ianlancetaylor commented Oct 21, 2016

banditsmile commented Oct 22, 2016

ianlancetaylor commented Oct 22, 2016

gopherbot commented Nov 16, 2016

gdsotirov commented Dec 2, 2016

minux commented Dec 2, 2016 via email

ALTree commented Dec 2, 2016 •

edited

minux commented Dec 2, 2016 via email

ALTree commented Dec 2, 2016

gdsotirov commented Dec 2, 2016

minux commented Dec 2, 2016 via email

gdsotirov commented Dec 2, 2016

bradfitz commented Dec 2, 2016

gopherbot commented Dec 6, 2016

gopherbot commented Jan 24, 2017

time: TestLoadFixed failure #17276

time: TestLoadFixed failure #17276

Comments

ALTree commented Sep 29, 2016 • edited

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you see?

ALTree commented Sep 29, 2016 • edited

ALTree commented Sep 29, 2016

ALTree commented Sep 29, 2016

lfam commented Oct 21, 2016

ianlancetaylor commented Oct 21, 2016

banditsmile commented Oct 22, 2016

ianlancetaylor commented Oct 22, 2016

gopherbot commented Nov 16, 2016

gdsotirov commented Dec 2, 2016

minux commented Dec 2, 2016 via email

ALTree commented Dec 2, 2016 • edited

minux commented Dec 2, 2016 via email

ALTree commented Dec 2, 2016

gdsotirov commented Dec 2, 2016

minux commented Dec 2, 2016 via email

gdsotirov commented Dec 2, 2016

bradfitz commented Dec 2, 2016

gopherbot commented Dec 6, 2016

gopherbot commented Jan 24, 2017

ALTree commented Sep 29, 2016 •

edited

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

ALTree commented Sep 29, 2016 •

edited

ALTree commented Dec 2, 2016 •

edited