New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/crypto/acme: provide mock implementation for tests #17251
Milestone
Comments
CL https://golang.org/cl/41731 mentions this issue. |
Sorry that was wrong CL. But I'm definitely planning on fixing this one, too. |
There's now https://github.com/letsencrypt/pebble, which is testing-oriented set of packages/mini implementation of the upcoming Let's Encrypt v2 endpoint. Might be useful. |
Change https://golang.org/cl/125495 mentions this issue: |
gopherbot
pushed a commit
to golang/crypto
that referenced
this issue
Jul 23, 2018
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 28, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
c-expert-zigbee
pushed a commit
to c-expert-zigbee/crypto_go
that referenced
this issue
Mar 29, 2022
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
LewiGoddard
pushed a commit
to LewiGoddard/crypto
that referenced
this issue
Feb 16, 2023
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
BiiChris
pushed a commit
to BiiChris/crypto
that referenced
this issue
Sep 15, 2023
Because tls.Config now requires more fields to be set in order for tls-alpn to work, Manager provides a new TLSConfig method for easier setup. This CL also adds a new internal package for end-to-end tests. The package implements a simple ACME CA server. Fixes golang/go#25013 Fixes golang/go#25901 Updates golang/go#17251 Change-Id: I2687ea8d5c445ddafad5ea2cdd36cd4e7d10bc86 Reviewed-on: https://go-review.googlesource.com/125495 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Without faking out the whole of GetCertificate, it's not easy
to test an autocert-based system, and doing things that way
leaves substantial room for getting the Manager configuration
wrong.
The autocert tests contain an ACME CA server stub - maybe that
could be made available publicly in some form.
The text was updated successfully, but these errors were encountered: