Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: test/fixedbugs/issue16016.go is flaky on linux-arm64 builder #17186

Closed
cherrymui opened this issue Sep 21, 2016 · 4 comments
Closed

cmd/compile: test/fixedbugs/issue16016.go is flaky on linux-arm64 builder #17186

cherrymui opened this issue Sep 21, 2016 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@cherrymui
Copy link
Member

Flaky builder failures start from commit 31ba855. This commit seems not related, so I guess it actually starts one commit earlier, ca4089a, and being lucky on that time.
@cherrymui cherrymui added this to the Go1.8 milestone Sep 21, 2016
@cherrymui cherrymui self-assigned this Sep 21, 2016
@cherrymui
Copy link
Member Author

On AMD64:

issue16016.go:13: live at entry to (*T).Foo: vals
issue16016.go:14: live at call to assertE2T2: v
issue16016.go:27: live at call to newobject: autotmp_7
issue16016.go:27: live at call to writebarrierptr: autotmp_7
issue16016.go:32: live at call to newproc: autotmp_7
issue16016.go:29: live at entry to main.func1: q
issue16016.go:30: live at call to newobject: q autotmp_8
issue16016.go:30: live at call to convT2E: q autotmp_8 autotmp_11
issue16016.go:30: live at call to writebarrierptr: q autotmp_8 autotmp_11
issue16016.go:30: live at call to deferproc: autotmp_8
issue16016.go:30: live at call to deferreturn: autotmp_8
<autogenerated>:1: live at entry to (*R).Foo: .this vals
<autogenerated>:2: live at entry to R.Foo: .this vals
<autogenerated>:3: live at entry to Q.Foo: .this .anon0

On ARM64:

issue16016.go:13: live at entry to (*T).Foo: vals
issue16016.go:14: live at call to assertE2T2: v
issue16016.go:27: live at call to newobject: autotmp_7
issue16016.go:27: live at call to writebarrierptr: autotmp_7
issue16016.go:32: live at call to newproc: autotmp_7
issue16016.go:29: live at entry to main.func1: q
issue16016.go:30: live at call to newobject: q autotmp_8
issue16016.go:30: live at call to convT2E: q autotmp_8 autotmp_11
issue16016.go:30: live at call to writebarrierptr: q autotmp_8 autotmp_11
issue16016.go:30: live at call to deferproc: autotmp_8
issue16016.go:30: live at call to deferreturn: autotmp_8
<autogenerated>:1: live at entry to (*R).Foo: .this  // <----- vals is not live here
<autogenerated>:2: live at entry to R.Foo: .this vals
<autogenerated>:3: live at entry to Q.Foo: .this .anon0

@cherrymui
Copy link
Member Author

also happens on mips64: https://build.golang.org/log/d72f4344d7a6b7ebffe87ab8c852bfb8ad6667f7

@gopherbot
Copy link

CL https://golang.org/cl/29570 mentions this issue.

@gopherbot
Copy link

CL https://golang.org/cl/29652 mentions this issue.

gopherbot pushed a commit that referenced this issue Sep 22, 2016
@cherrymui
test: errorcheck auto-generated functions
d586aae 
Add an "errorcheckwithauto" action which performs error check
including lines with auto-generated functions (excluded by
default). Comment "// ERRORAUTO" matches these lines.

Add testcase for CL 29570 (as an example).

Updates #16016, #17186.

Change-Id: Iaba3727336cd602f3dda6b9e5f97dafe0848e632
Reviewed-on: https://go-review.googlesource.com/29652
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
@golang golang locked and limited conversation to collaborators Sep 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
2 participants
@gopherbot @cherrymui