Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: misaligned text for covariant result types section of FAQ #17170

Closed
StevenMaude opened this issue Sep 20, 2016 · 2 comments
Closed

doc: misaligned text for covariant result types section of FAQ #17170

StevenMaude opened this issue Sep 20, 2016 · 2 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Milestone

Comments

@StevenMaude
Copy link

What version of Go are you using (go version)?

1.7.1

What did you expect to see?

A body text layout as for the rest of the FAQ, for instance in the "Why is my nil error value not equal to nil?" section:

correct-layout

What did you see instead?

Text that's to the left and right of what's considered the text margins for the FAQ body:

covariant-types-layout

Fix

The inconsistent use of <p> tags is the cause of the difference; see the covariant return section compared with the nil error value section.

Changing the relevant HTML to:

<p>
Covariant result types would mean that an interface like
</p>

<pre>
type Copyable interface {
    Copy() interface{}
}
</pre>

<p>
would be satisfied by the method
</p>

fixes this:

covariant-types-layout-fixed

@bradfitz bradfitz self-assigned this Sep 20, 2016
@bradfitz bradfitz added the Documentation Issues describing a change to documentation. label Sep 20, 2016
@bradfitz bradfitz added this to the Go1.8 milestone Sep 20, 2016
@bradfitz
Copy link
Contributor

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/29442 mentions this issue.

@golang golang locked and limited conversation to collaborators Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants