Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: accept space-separated tag list, like cmd/go #17148

Closed
yaojingguo opened this issue Sep 18, 2016 · 3 comments
Closed

cmd/vet: accept space-separated tag list, like cmd/go #17148

yaojingguo opened this issue Sep 18, 2016 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@yaojingguo
Copy link
Contributor

yaojingguo commented Sep 18, 2016 •
edited

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

Now different go cmds handle tag list in different ways:

  • go build , go test and go vet accepts space-separated tag list.
  • go tool vet accepts comma-separated tag list. go tool vet -h says:
  -tags string
        comma-separated list of build tags to apply when parsing

If these cmds handle tag list in a consistent way, it will be easier for users to use them.
@yaojingguo yaojingguo mentioned this issue Sep 18, 2016
Merged
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 3, 2016
@quentinmit quentinmit added this to the Go1.8Maybe milestone Oct 3, 2016
@quentinmit
Copy link
Contributor

quentinmit commented Oct 3, 2016 •
edited

This probably means we need to accept both comma and space separated lists to avoid breaking any existing callers.

@quentinmit quentinmit mentioned this issue Oct 3, 2016
Closed
@quentinmit quentinmit mentioned this issue Oct 17, 2016
Closed
@rakyll rakyll changed the title cmd: inconsistent handing of tag list cmd/go: inconsistent handing of tag list Oct 20, 2016
@rsc
Copy link
Contributor

rsc commented Oct 20, 2016

go tool vet added its tag list much more recently than the others. I think we can change vet to take spaces too, but we're not going to change the go command proper to start taking commas.

@rsc rsc modified the milestones: Go1.8, Go1.8Maybe Oct 20, 2016
@rsc rsc changed the title cmd/go: inconsistent handing of tag list cmd/vet: accept space-separated tag list, like cmd/go Oct 20, 2016
@gopherbot
Copy link

CL https://golang.org/cl/32030 mentions this issue.

@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
4 participants
@rsc @quentinmit @yaojingguo @gopherbot