Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/scrypt: fix scrypt example #17046

Closed
leonklingele opened this issue Sep 9, 2016 · 0 comments
Closed

x/crypto/scrypt: fix scrypt example #17046

leonklingele opened this issue Sep 9, 2016 · 0 comments
Labels
Documentation FrozenDueToAge help wanted
Milestone
Unreleased

Comments

@leonklingele
Copy link
Contributor

The scrypt code example doesn't work, as scrypt.Key also returns an error.

dk := scrypt.Key([]byte("some password"), salt, 16384, 8, 1, 32)
-->
dk, err := scrypt.Key([]byte("some password"), salt, 16384, 8, 1, 32)

https://github.com/golang/crypto/blob/05d11b2ca14108dfc7f74f4f66b28c7fe92e1fd0/scrypt/scrypt.go#L221
@bradfitz bradfitz added this to the Unreleased milestone Sep 9, 2016
@bradfitz bradfitz changed the title Crypto: Fix scrypt example x/crypto/scrypt: fix scrypt example Sep 9, 2016
@golang golang locked and limited conversation to collaborators Sep 10, 2017
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@SamWhited @bradfitz
scrypt: fix broken example in documentation
f112038 
Fixes golang/go#17046

Change-Id: I7fa7e0b700212992125de32524801048b56ac5d1
Reviewed-on: https://go-review.googlesource.com/28952
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@SamWhited @bradfitz
scrypt: fix broken example in documentation
7223ea5 
Fixes golang/go#17046

Change-Id: I7fa7e0b700212992125de32524801048b56ac5d1
Reviewed-on: https://go-review.googlesource.com/28952
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@SamWhited @bradfitz
scrypt: fix broken example in documentation
d25779d 
Fixes golang/go#17046

Change-Id: I7fa7e0b700212992125de32524801048b56ac5d1
Reviewed-on: https://go-review.googlesource.com/28952
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@SamWhited @bradfitz
scrypt: fix broken example in documentation
02efdf1 
Fixes golang/go#17046

Change-Id: I7fa7e0b700212992125de32524801048b56ac5d1
Reviewed-on: https://go-review.googlesource.com/28952
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @leonklingele @gopherbot