Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/goimports: #17013

Closed
tomerf8 opened this issue Sep 7, 2016 · 1 comment
Closed

x/tools/cmd/goimports: #17013

tomerf8 opened this issue Sep 7, 2016 · 1 comment

Comments

@tomerf8
Copy link

tomerf8 commented Sep 7, 2016

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.6.2 (appengine-1.9.40) darwin/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tomerf/go"
GORACE=""
GOROOT="/usr/local/go_appengine/goroot"
GOTOOLDIR="/usr/local/go_appengine/goroot/pkg/tool/darwin_amd64"
GO15VENDOREXPERIMENT="1"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?

go get -u golang.org/x/tools/cmd/goimports

What did you expect to see?

goimports installed

What did you see instead?

# golang.org/x/tools/imports
src/golang.org/x/tools/imports/fastwalk_unix.go:23: readDir redeclared in this block
        previous declaration at src/golang.org/x/tools/imports/fastwalk_portable.go:18
@bradfitz
Copy link
Contributor

bradfitz commented Sep 7, 2016

This is almost certainly because you're using the AppEngine version of Go to fetch a binary, and it's making assumptions about dependent packages that you want to run them on App Engine.

Use the normal Go binary to install goimports.

/cc @okdave @broady (Is there anything to do here?)

@bradfitz bradfitz closed this as completed Sep 7, 2016
@golang golang locked and limited conversation to collaborators Sep 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants