/cc @bradfitz

The delta between ConnectDone and GotConn is the TLS negotiation time. My understanding is that ConnectDone means "TCP dial completed" and GotConn means the http package received a connection on which it can begin sending HTTP requests. The TLS handshake happens between those two events.

If nothing else, the godocs could be updated to make this more apparent.

If there is interest in a CL for this I will submit one. I was thinking of adding the following methods to httptrace.ClientTrace:

    // TLSHandshakeStart is called when tls.Handshake() is started.
    // When connecting to a https destination through a https proxy
    // TLSHandshakeStart could be called twice
    TLSHandshakeStart func()

    // TLSHandshakeDone is called after tls.Handshake is done
    // When connecting to a https destination through a https proxy
    // TLSHandshakeDone could be called twice.
    TLSHandshakeDone func(tls.ConnectionState)

The "could be called twice" part is a little confusing. It should probably distinguish which conn it is.

How do we deal with the proxy conn stuff elsewhere in httptrace?

@bradfitz Looks like I misread the code last night.

How just this instead...

    // TLSHandshakeStart is called when tls.Handshake() is started.
    TLSHandshakeStart func()

    // TLSHandshakeDone is called after tls.Handshake is done
    TLSHandshakeDone func(tls.ConnectionState)

Side Note: When we connect to a https site through a http proxy, the TLSHandshakeStart/Done fire after the CONNECT bridges the connection through the proxy. Not sure if we should bother calling that out or not.

CL https://golang.org/cl/30359 mentions this issue.