New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: nil pointer dereference in walk #16940
Comments
Which test? (which source code reproduces this?) |
I confirm that the offending commit is e6f9f39. |
Thanks for confirming. @dsnet, would you please revert that commit. On Thu, Sep 1, 2016 at 9:11 AM, Joe Tsai notifications@github.com wrote:
|
How urgent is this, @dsnet? Can we try rolling forward? |
AFK but my guess from my recollection of that CL is that the error stems from something like |
Not urgent. It was 1 build failure out of many thousands (passing). I should also note that I'm discovering these issues from work intended to discover bugs earlier on in the development cycle. |
I would prefer to continue the practice of reverting changes rather than On Thu, Sep 1, 2016 at 10:55 AM, Joe Tsai notifications@github.com wrote:
|
Reproduction: package src
func f(n T) []byte { return make([]byte, 0, T(0i)) }
type T complex64 Will send a fix tomorrow if @martisch doesn't beat me to it. As for "muscling through", new code will frequently introduce bugs. Reverting on every single bug, during the open dev period, will add a lot of overhead. I am all for reverting when it's during the freeze, or it causes significant breakage that might impede other developers or cause unnoticed further build breakage, or the bug is subtle or unknown and might take a long time to track down, etc. This is a small bug with a minor impact and a minor fix. Let's just fix it.
Ouch. |
I'm fine rolling forward here if the fix is known and everybody can work and build.golang.org isn't all red and impeding workflows. This just broke on some internal Google code on a test run of tip Go, not affecting anybody, so yay... @dsnet's early testing of Go 1.8 is already bearing fruit. |
Working on the fix and new test cases. |
CC me on the fix and I'll test the change on the failing test case. |
CL https://golang.org/cl/28301 mentions this issue. |
Using ffa2bd2. The offending commit is probably something recent (last 2 weeks).
I'm seeing this compiler failure building a (proprietary) test:
\cc @randall77 @mdempsky @ianlancetaylor
I'm still trying to strip the offending code into a smaller reproduction. Any advice on how to isolate the problem is welcome.
The text was updated successfully, but these errors were encountered: