Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: SHA sums per binary release's download button are non selectable nor copyable #16900

Closed
metaforte opened this issue Aug 27, 2016 · 6 comments
Closed

website: SHA sums per binary release's download button are non selectable nor copyable #16900

metaforte opened this issue Aug 27, 2016 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8Maybe

Comments

@metaforte
Copy link

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
    1.6
  2. What operating system and processor architecture are you using (go env)?
    ubuntu
  3. What did you do?
    Opened golang website. and clicked downloads link
  4. What did you expect to see?
    The sha sum in the download button is too small and not available for copying.
    The same sha sum is available down the page in stable releases section.
    So we have sha sum duplicated on the same page

Please replace the small "not copy-able" sha text in the download button with a clickable link pointing to the sha in the stable releases section.
@odeke-em odeke-em changed the title The sha sums in the download button are not selectable and therefore cannot be copied website: SHA sums per binary release's download button are non selectable nor copyable Aug 27, 2016
@bradfitz
Copy link
Contributor

Indeed. Thanks for the bug report.

/cc @broady

@bradfitz bradfitz added this to the Go1.8 milestone Aug 27, 2016
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 10, 2016
@bradfitz
Copy link
Contributor

Ping @broady.

@bradfitz bradfitz modified the milestones: Go1.8Maybe, Go1.8 Nov 15, 2016
@broady
Copy link
Member

broady commented Nov 15, 2016

Given that the "Featured downloads" section is a subset of the latest stable version download, I think we should just remove it from the "Feature download" section.

The SHA sums are clearly visible in the section below.

@gopherbot
Copy link

CL https://golang.org/cl/33290 mentions this issue.

@broady
Copy link
Member

broady commented Nov 15, 2016

This will go live once 1.8 lands, unless we cherry-pick it before then.

@dmitshur
Copy link
Contributor

I'm okay with them being removed for reason @broady stated, but want to share an observation. Even though that SHA sum text was neither selectable nor copyable, it was "findable", which is helpful to verify a file you've downloaded is the featured download you expect. E.g., see this screenshot. It's still findable in the section below so I expect that it's fine.

@golang golang locked and limited conversation to collaborators Nov 16, 2017
@rsc rsc unassigned broady Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
6 participants
@bradfitz @broady @quentinmit @dmitshur @gopherbot @metaforte