-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go: inconsistent import panic #16859
Comments
@tw4452852 What does "sometimes" mean? Do you run golint multiple times? Also, can you see if you still have packages installed that are compiled with an older compiler? Specifically, please look at (open in an editor) the file If you have an up-to-date std library (all compiled with latest compiler), please provide more detailed instructions how to recreate this error (which version of golint, other packages installed). Thanks. Please also note that we don't guarantee interoperability of package files between different compiler versions - and it looks like you're working with a compiler off tip. |
Yes, I run
I use the tip:
And here is first 20 lines of
As for As for reproduce steps:
|
I had a similar thing recently after upgrading to 1.7. My issue was with go vet (the same as #16112). I blew away the contents of $GOPATH/pkg and now it seems fine |
@tw4452852 I cannot reproduce this on my machine, even with dozens of golint calls. I'm at go version devel +8f3c8a3 Fri Aug 26 20:06:58 2016 +0000 darwin/amd64 (at commit 8f3c8a3). I installed the same version of golint as you have. And I installed caddy per the instructions (at commit 191ec27c261553c429cf5d6df2d14dce386417ff) I'm not sure how it's possible for golint to pass sometimes and sometimes not, w/o changes to the files being linted. At least the import/export code is very deterministic. I've tried this also with my latest devel version (not yet committed) that has better support for export format version skew detection - same result. I suspect that you still have some package files that use an outdated format somewhere. I'd recommend blowing away all installed package files and to recompile with the latest compiler. I'm reasonably confident that this will solve the problem. I have several pending changes (see #16881) which should hopefully make these errors a thing of the past. Closing for now. If you still see a problem after re-installing your packages and upgrading to the latest compiler, please re-open this. Thanks. |
Please answer these questions before submitting your issue. Thanks!
go version
)?go version devel +00b779a Wed Aug 17 03:12:29 2016 +0000 linux/amd64
go env
)?golint github.com/mholt/caddy/caddyhttp/proxy
No errors.
Panic sometimes:
The text was updated successfully, but these errors were encountered: