Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme/autocert: Certificate renewal broken #16851

Closed
takeyourhatoff opened this issue Aug 23, 2016 · 4 comments
Closed

x/crypto/acme/autocert: Certificate renewal broken #16851

takeyourhatoff opened this issue Aug 23, 2016 · 4 comments
Labels
FrozenDueToAge

Comments

@takeyourhatoff
Copy link

It looks like when a certificate expires, autocert will not renew it but instead just hangup incoming TLS connections.

Offending line:

https://github.com/golang/crypto/blob/b35ccbc95a0eaae49fb65c5d627cb7149ed8d1ab/acme/autocert/autocert.go#L270
@bradfitz
Copy link
Contributor

The package isn't done. @crhym3 knows.

@x1ddos
Copy link

x1ddos commented Aug 23, 2016

Yes, working on it right now.

@x1ddos
Copy link

x1ddos commented Aug 23, 2016

Can't assign this to myself.

@x1ddos
Copy link

x1ddos commented Aug 31, 2016

Fixed by golang/crypto@33b4182.
This can be closed now. I think I referenced this issue from the commit incorrectly, so it didn't show up here.

@golang golang locked and limited conversation to collaborators Aug 31, 2017
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Nov 24, 2019
acme/autocert: implement certificates renewal
33b4182 
A cert renewal loop is started when a certificate is fetched
from cache for the first time or a new one is created.
At most one renew loop is running per domain.

Closes golang#16851

Change-Id: I3d5821d8d76e9f2d9b551d0976ebc4cf91647092
Reviewed-on: https://go-review.googlesource.com/27611
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@rsc rsc unassigned x1ddos Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @x1ddos @takeyourhatoff @gopherbot