Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: optimize x > a && x < b to uint(x - a) < b - a when a, b are constants and b > a #16697

Closed
minux opened this issue Aug 15, 2016 · 3 comments
Closed

cmd/compile: optimize x > a && x < b to uint(x - a) < b - a when a, b are constants and b > a #16697

minux opened this issue Aug 15, 2016 · 3 comments
Labels
FrozenDueToAge Performance
Milestone
Go1.8Maybe

Comments

@minux
Copy link
Member

minux commented Aug 15, 2016

https://golang.org/cl/27032 demonstrated that by doing this
transformation, ~10% improvement can be seen in benchmarks
from the unicode package
@minux minux added this to the Go1.8Maybe milestone Aug 15, 2016
@hirochachacha hirochachacha mentioned this issue Aug 15, 2016
Closed
@josharian
Copy link
Contributor

I have a CL for this ready. Just haven't mailed it yet.

@josharian josharian self-assigned this Aug 15, 2016
@hirochachacha
Copy link
Contributor

That sounds good!

@minux minux changed the title cmd/compiler: optimize x > a && x < b to uint(x - a) < b - a when a, b are constants and b > a cmd/compile: optimize x > a && x < b to uint(x - a) < b - a when a, b are constants and b > a Aug 15, 2016
@gopherbot
Copy link

CL https://golang.org/cl/27652 mentions this issue.

@dsnet dsnet mentioned this issue Oct 7, 2016
Closed
@golang golang locked and limited conversation to collaborators Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Performance
Projects
None yet
Milestone
Go1.8Maybe
Development

No branches or pull requests
4 participants
@josharian @minux @hirochachacha @gopherbot