Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: proposed wording change for context #16642

Closed
MichaelTJones opened this issue Aug 8, 2016 · 4 comments
Closed

doc: proposed wording change for context #16642

MichaelTJones opened this issue Aug 8, 2016 · 4 comments

Comments

@MichaelTJones
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

1.7rc6

  1. What operating system and processor architecture are you using (go env)?

moot

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
    A complete runnable program is good.
    A link on play.golang.org is best.

moot

  1. What did you expect to see?

moot

  1. What did you see instead?

Introductory paragraph on "what's changed" reads:

The release adds a port to IBM LinuxOne; updates the x86-64 compiler back end to generate more efficient code; includes the context package, promoted from the x/net subrepository and now used in the standard library; and adds support in the testing package for creating hierarchies of tests and benchmarks. The release also finalizes the vendoring support started in Go 1.5, making it a standard feature.

Proposed change permutes the reference order within the third clause...

The release adds a port to IBM LinuxOne; updates the x86-64 compiler back end to generate more efficient code; promotes the context package from the x/net subrepository to the standard library; and adds support in the testing package for creating hierarchies of tests and benchmarks. The release also finalizes the vendoring support started in Go 1.5, making it a standard feature.

@broady
Copy link
Contributor

broady commented Aug 9, 2016

This does miss one small note, that the context package is now used in the standard library. I'll try to retain that.

@broady
Copy link
Contributor

broady commented Aug 9, 2016

@MichaelTJones I can't think of wording that retains the information that context is used within the standard library better than the way it is currently.

If you can, please suggest it.

@broady broady changed the title Proposed wording change for release notes doc: proposed wording change for context Aug 9, 2016
@broady broady added this to the Go1.7Maybe milestone Aug 9, 2016
@MichaelTJones
Copy link
Contributor Author

Hmm… How about:

promoted the context package from the

x/net subrepository

into and used by the standard library;

From: Chris Broadfoot notifications@github.com
Reply-To: golang/go reply@reply.github.com
Date: Monday, August 8, 2016 at 5:17 PM
To: golang/go go@noreply.github.com
Cc: Michael Jones michael.jones@gmail.com, Mention mention@noreply.github.com
Subject: Re: [golang/go] Proposed wording change for release notes (#16642)

@MichaelTJones I can't think of wording that retains the information that context is used within the standard library better than the way it is currently.

If you can, please suggest it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@quentinmit
Copy link
Contributor

Go 1.7 has been shipped now.

@golang golang locked and limited conversation to collaborators Aug 25, 2017
@rsc rsc unassigned broady Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants