You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comment at the top indicates an int32 return value, and the second to last line confirms that. However, the Go function prototype (runtime/netpoll_{epoll,kqueue}.go) has no return value:
funccloseonexec(fdint32)
And openbsd/arm appears to be the only platform in which we attempt to return a value.
Discovered while working on the interminable (but valuable?) #11041.
Input requested. Should we:
eliminate the bad ret value write in openbsd/arm
accept a return value from closeonexec, update all the other platforms to provide it, and then use it
The text was updated successfully, but these errors were encountered:
There is no reasonable action the runtime can take if closeonexec fails, other than simply carry on, and there is no actual likelihood of failure, so I think we should consistently not return a value.
Quoting runtime/sys_openbsd_arm.s:
The comment at the top indicates an int32 return value, and the second to last line confirms that. However, the Go function prototype (runtime/netpoll_{epoll,kqueue}.go) has no return value:
And openbsd/arm appears to be the only platform in which we attempt to return a value.
Discovered while working on the interminable (but valuable?) #11041.
Input requested. Should we:
The text was updated successfully, but these errors were encountered: