crypto/rsa: GenerateKey never returns on some values of bits #16596
Labels
Milestone
Comments
|
Docs issue. crypto/rsa.GenerateKey doesn't support generating
toy keys (<7 bits).
|
|
How about returning an error or even panicking? |
|
@minux doesn't seem like it works for even 8 bit keys https://play.golang.org/p/a7Ig2HcKzz, but it does work for 7 bits. |
|
A panic would be fine. But an error would be even better, since the function already returns an error. |
bradfitz
changed the title
|
8 bit key generation is failing because of how prime numbers are generated, only possible 4 bit prime that can be generated is 13 while the function requires two distinct primes. 7 works as it generates one 4 bit and one 3 bit prime similar case for 5 |
|
CL https://golang.org/cl/25561 mentions this issue. |
|
CL https://golang.org/cl/28969 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
go version)?go1.6.3
go env)?windows10/amd64
ubuntu16.04/amd64
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
https://play.golang.org/p/gYYUDxj6Z5
The text was updated successfully, but these errors were encountered: