Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/doc: incorrect handling of some embedded interfaces #16567

Closed
dsnet opened this issue Aug 2, 2016 · 0 comments
Closed

cmd/doc: incorrect handling of some embedded interfaces #16567

dsnet opened this issue Aug 2, 2016 · 0 comments

Comments

@dsnet
Copy link
Member

dsnet commented Aug 2, 2016

Using go1.7rc2

1082184 caused a regression from Go1.6.

Currently I see:

$ go doc runtime.Error
type Error interface {

    // RuntimeError is a no-op function but
    // serves to distinguish types that are run time
    // errors from ordinary errors: a type is a
    // run time error if it has a RuntimeError method.
    RuntimeError()
    // Has unexported methods.
}

$ go doc compress/flate Reader
doc: invalid program: unexpected type for embedded field
doc: invalid program: unexpected type for embedded field
type Reader interface {
    io.Reader
    io.ByteReader
}

I expect to see:

$ go doc runtime.Error
type Error interface {
    error

    // RuntimeError is a no-op function but
    // serves to distinguish types that are run time
    // errors from ordinary errors: a type is a
    // run time error if it has a RuntimeError method.
    RuntimeError()
}

$ go doc compress/flate Reader
type Reader interface {
    io.Reader
    io.ByteReader
}
@dsnet dsnet added this to the Go1.7Maybe milestone Aug 2, 2016
@dsnet dsnet self-assigned this Aug 2, 2016
@golang golang locked and limited conversation to collaborators Aug 2, 2017
@rsc rsc unassigned dsnet Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants