Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/doc: ToHTML does not properly handle URLs containing semicolons #16565

Closed
mdlayher opened this issue Aug 1, 2016 · 2 comments
Closed

go/doc: ToHTML does not properly handle URLs containing semicolons #16565

mdlayher opened this issue Aug 1, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@mdlayher
Copy link
Member

mdlayher commented Aug 1, 2016

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?
go version go1.6.3 linux/amd64
  1. What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/matt/git/go"
GORACE=""
GOROOT="/home/matt/.gvm/gos/go1.6.3"
GOTOOLDIR="/home/matt/.gvm/gos/go1.6.3/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"
  1. What did you do?
    If possible, provide a recipe for reproducing the error.
    A complete runnable program is good.
    A link on play.golang.org is best.

https://play.golang.org/p/s7-kyuoQx3

Credit to @normanvashon for this example and diagnosing the bug in go/doc here: golang/gddo#406 (comment).

  1. What did you expect to see?

The entire git.qemu.org URL should be hyperlinked.

  1. What did you see instead?

The hyperlink is cut off right before the first semicolon.

I have a patch ready and will submit a CL for this in the next few minutes.
@bradfitz bradfitz added this to the Go1.8 milestone Aug 1, 2016
@gopherbot
Copy link

CL https://golang.org/cl/25385 mentions this issue.

@bradfitz
Copy link
Contributor

bradfitz commented Aug 1, 2016

Looking at that regexp in the CL, looks like it also doesn't handle IPv6 addresses: https://play.golang.org/p/PvwsEXAwWR

Probably doesn't matter, though.

@mdlayher mdlayher mentioned this issue Aug 1, 2016
Closed
@golang golang locked and limited conversation to collaborators Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
3 participants
@bradfitz @mdlayher @gopherbot