Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/term: IsTerminal #16518

Closed
techtonik opened this issue Jul 27, 2016 · 5 comments
Closed

x/term: IsTerminal #16518

techtonik opened this issue Jul 27, 2016 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@techtonik
Copy link

I've added code to x/term https://github.com/techtonik/term/tree/isterm to fix #16420

I can't mail them:

>git codereview mail
remote: Processing changes: refs: 1, done
To https://go.googlesource.com/go
 ! [remote rejected] HEAD -> refs/for/master (no common ancestry)
error: failed to push some refs to 'https://go.googlesource.com/go'
(running: git push -q origin HEAD:refs/for/master)
git-codereview: exit status 1

Should the function be called IsTerminal, IsConsole or IsInteractive?
@techtonik
Copy link
Author

@mattn can we get get https://github.com/mattn/go-isatty in here?

@mattn
Copy link
Member

mattn commented Jul 28, 2016

What do you mean get? If you mean about using my codes on go-isatty, I am okay and feel free to use.

@minux
Copy link
Member

minux commented Jul 28, 2016 via email

@quentinmit quentinmit added this to the Unreleased milestone Jul 29, 2016
@techtonik
Copy link
Author

Submitted. https://go-review.googlesource.com/38050

git-codereview doesn't support cloning from GitHub and then changing remote 'origin' (change command fails to detect changes), so I have to git clone https://go.googlesource.com/term, then git pull git@github.com:techtonik/term isterm and only then it worked.

@ysmolski
Copy link
Member

ysmolski commented Mar 4, 2018

I think this issue was solved and it's not a proper bug. ping @bradfitz

@andybons andybons closed this as completed Mar 4, 2018
@golang golang locked and limited conversation to collaborators Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
7 participants
@mattn @quentinmit @minux @ysmolski @andybons @techtonik @gopherbot