Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: flaky TestH12_RequestContentLength_Known_NonZero #16496

Closed
bradfitz opened this issue Jul 26, 2016 · 1 comment
Closed

net/http: flaky TestH12_RequestContentLength_Known_NonZero #16496

bradfitz opened this issue Jul 26, 2016 · 1 comment
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8Early

Comments

@bradfitz
Copy link
Contributor

Just noticed:

https://build.golang.org/log/31bace9ed1c8e96d66019498ea7538fe78cddedd

...
--- FAIL: TestH12_RequestContentLength_Known_NonZero (0.00s)
    clientserver_test.go:185: HTTP/2 request: Post https://127.0.0.1:56615: http2: stream closed
FAIL
FAIL    net/http    9.285s
...

Maybe it's another case of #16029 in which case this test could just be made more robust.
@bradfitz bradfitz added this to the Go1.8Early milestone Jul 26, 2016
@bradfitz bradfitz self-assigned this Jul 26, 2016
@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 26, 2016
@bradfitz
Copy link
Contributor Author

bradfitz commented Sep 1, 2016

After a bunch of time trying to reproduce this and reading the code again, it looks like this was fixed via golang/net@3797cd8 which was 9 days before this bug report, but that commit wasn't bundled into std until 66b4743, two days after this bug report.

So all good. (famous last words)

@bradfitz bradfitz closed this as completed Sep 1, 2016
@golang golang locked and limited conversation to collaborators Sep 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8Early
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot