-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: net/texproto: add missing MIMEHeader.Write() #16479
Comments
For backwards-compatibility reasons we'll have to keep around a Header.Write, of course. |
CL https://golang.org/cl/25341 mentions this issue. |
Copy of comment from CL: Do we really want to add a WriteSubset method to the textproto package? It's weird enough in net/http in retrospect. If textproto needs this functionality, then I'd rather move the bulk of the logic to an internal shared package so we don't need to expose WriteSubset. |
So the idea would be to add Another solution would be to implement |
As long as we don't add more public API. |
Let's leave things alone for Go 1.8. |
Looks like the CL https://go-review.googlesource.com/c/go/+/25341/ was abandoned with a reasoning of we don't want to make the change, cc @rsc |
The CL doesn't mention any NACK. Brad said we shouldn't expose |
That was my direct reading of the abandonment. Also adding that method without a proposal is no longer feasible, so I am going to repurpose this issue as a proposal that’ll go through a review. |
I have no longer interest in this. |
http.Header
is using many methods fromtextproto.MIMEHeader
(see https://golang.org/src/net/http/header.go), buttextproto.MIMEHeader
is missing aWrite
method. This method is implemented innet/http
. It seems weird to importnet/http
each time atextproto.MIMEHeader
needs to be formatted. TheWrite
method could instead be moved tonet/textproto
, and called innet/http
as it's done for several other functions.The text was updated successfully, but these errors were encountered: