Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: wrong Dirent is defined in linux mips64x. #16435

Closed
hirochachacha opened this issue Jul 20, 2016 · 2 comments
Closed

x/sys/unix: wrong Dirent is defined in linux mips64x. #16435

hirochachacha opened this issue Jul 20, 2016 · 2 comments
Labels
FrozenDueToAge

Comments

@hirochachacha
Copy link
Contributor

syscall package defines

// Note: on mips64, we're using the getdents syscall,
// so the Dirent struct is different.

type Dirent struct {
    Ino       uint64
    Off       int64
    Reclen    uint16
    Name      [256]int8
    Type      uint8
    Pad_cgo_0 [5]byte
}

On the other hand, x/sys/unix package defines

type Dirent struct {
    Ino       uint64
    Off       int64
    Reclen    uint16
    Type      uint8
    Name      [256]int8
    Pad_cgo_0 [5]byte
}

x/sys/unix should be fixed.
@hirochachacha hirochachacha changed the title x/sys/unix: wrong Dirent is used in linux mips64x. x/sys/unix: wrong Dirent is defined in linux mips64x. Jul 20, 2016
@mattn mattn mentioned this issue Jul 20, 2016
Closed
@bradfitz
Copy link
Contributor

Why was this closed?

@bradfitz
Copy link
Contributor

Oh, I see #16399 (comment)

@golang golang locked and limited conversation to collaborators Jul 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @hirochachacha @gopherbot