Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: TestGuru, TestOracle fail on plan9 #16397

Closed
bradfitz opened this issue Jul 17, 2016 · 1 comment
Closed

x/tools/cmd/guru: TestGuru, TestOracle fail on plan9 #16397

bradfitz opened this issue Jul 17, 2016 · 1 comment
Labels
FrozenDueToAge OS-Plan9 Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@bradfitz
Copy link
Contributor

TestGuru and TestOracle fail on plan9, because the golden data makes assumptions about the stringification of a non-existent file error it seems:

https://build.golang.org/log/0d56657712d13b0adc05eb951dfaad5dc25edbfc

--- FAIL: TestGuru (129.51s)
    guru_test.go:276: Guru tests for testdata/src/referrers/main.go failed: exit status: 'diff 684: some'.
        testdata/src/referrers/main.golden:55,59 - testdata/src/referrers/main.got:55,59

          -------- @referrers ref-type-U --------
          references to type U int
        - open testdata/src/referrers/nosuchfile.y: no such file or directory (+ 1 more refs in this file)
        + open testdata/src/referrers/nosuchfile.y: 'testdata/src/referrers/nosuchfile.y' does not exist (+ 1 more refs in this file)


FAIL
FAIL    golang.org/x/tools/cmd/guru 129.546s

Because x/tools/cmd/guru/testdata/src/referrers/main.golden contains:

-------- @referrers ref-type-U --------
references to type U int
open testdata/src/referrers/nosuchfile.y: no such file or directory (+ 1 more refs in this file)

But plan9 stringifies it as:

open testdata/src/referrers/nosuchfile.y: 'testdata/src/referrers/nosuchfile.y' does not exist (+ 1 more refs in this file)

Not sure which side this should be fixed on.

But let's fix or disable the test on plan9, since we're trying to remove all the red from the dashboard as part of #11811

/cc @0intro @quentinmit
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Plan9 labels Jul 17, 2016
@gopherbot
Copy link

CL https://golang.org/cl/24968 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Plan9 Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @alandonovan @gopherbot