Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/cases: linker crash #16390

Closed
bradfitz opened this issue Jul 15, 2016 · 6 comments
Closed

x/text/cases: linker crash #16390

bradfitz opened this issue Jul 15, 2016 · 6 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bradfitz
Copy link
Contributor

Both the linux-amd64 and linux-amd64-nocgo builders are failing with Go 1.6:

https://build.golang.org/log/d2d3e2b25eb7f7940e0a2fd9c7e664297f040695
https://build.golang.org/log/aeac6e494aca0d048349019a986341d9c2d6accb

?       golang.org/x/text   [no test files]
go build testmain: /tmp/workdir/go/pkg/tool/linux_amd64/compile: signal: killed
go build testmain: /tmp/workdir/go/pkg/tool/linux_amd64/link: signal: killed
go build testmain: /tmp/workdir/go/pkg/tool/linux_amd64/link: signal: killed
FAIL    golang.org/x/text/cases [build failed]

(which causes the golang.org/x/text/language and golang.org/x/text/unicode/norm builds to fail, presumably)

@mpvl, any clue?

Massive memory usage by the linker? But it's fine with Go 1.5 and Go 1.7? Should we disable those tests if +build go1.6,!go1.7?

(part of #11811, cc @quentinmit)

@bradfitz bradfitz added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 15, 2016
@bradfitz bradfitz added this to the Unreleased milestone Jul 15, 2016
@mpvl
Copy link
Contributor

mpvl commented Jul 16, 2016

It is also flakey. The link succeeds on most trials even when there are unrelated changes.

@mpvl
Copy link
Contributor

mpvl commented Jul 16, 2016

This seems to somewhat more frequently with about 4 packages in the text repo (though still the minority of the builds) and less frequently with other packages. I suspect this linking resource issue can happen with many of the packages in the repo. So rather than exclude each package from testing, I would prefer if the framework could ignore or retry in case of flakey tests. Or allow for a manual retry option of some sort.

Or, we could remove the text repo from 1.6 altogether as to not give a false illusion that it is tested after marking half or all of the packages to be excluded from 1.6.

@mpvl
Copy link
Contributor

mpvl commented Jul 16, 2016

Actually, the same problem also exists on 1.5 and 1.7. So I propose increasing the timeouts.

@bradfitz
Copy link
Contributor Author

So I propose increasing the timeouts.

What timeout?

I see no use of the time package in that code.

I had guessed it was a memory issue.

/cc @quentinmit

@mpvl
Copy link
Contributor

mpvl commented Jul 17, 2016

Ah. Either way, I don't think I can do much on my side. The building is flakey, so I think the only thing to do is to either raise some limits or increase capacity.

/cc @quentinmit

@mpvl
Copy link
Contributor

mpvl commented Oct 31, 2018

I believe this is no longer an issue.

@mpvl mpvl closed this as completed Oct 31, 2018
@golang golang locked and limited conversation to collaborators Oct 31, 2019
@rsc rsc unassigned mpvl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants