Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/guru: melpa go-guru incompatible with current 'go get' version #16351

Closed
samv opened this issue Jul 13, 2016 · 2 comments
Closed

x/tools/cmd/guru: melpa go-guru incompatible with current 'go get' version #16351

samv opened this issue Jul 13, 2016 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@samv
Copy link

samv commented Jul 13, 2016 •
edited

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

go version go1.6 darwin/amd64

  1. What operating system and processor architecture are you using (go env)?
  2. What did you do?
    If possible, provide a recipe for reproducing the error.
    A complete runnable program is good.
    A link on play.golang.org is best.

I first installed go guru via MELPA (version 20160712.622)

I then ran go get golang.org/x/tools/cmd/guru

I opened a go file and tried to run go-guru-definition (C-x C-o j) to jump to the definition of a file

  1. What did you expect to see?

Jump to the definition

  1. What did you see instead?

flag provided but not defined: -json

My workaround was to remove the melpa-sourced version of guru using rm -r ~/.emacs.d/elpa/go-guru* and then put some nonsense in my .emacs like

(load-file
 (concat (car (split-string (getenv "GOPATH") ":"))
  "/src/golang.org/x/tools/cmd/guru/go-guru.el")```
@ianlancetaylor ianlancetaylor changed the title melpa go-guru incompatible with current 'go get' version x/tools/cmd/guru: melpa go-guru incompatible with current 'go get' version Jul 13, 2016
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 13, 2016
@kostya-sh
Copy link
Contributor

go-guru.el from golang.org/x and go-guru.el from MELPA are identical: https://www.diffnow.com/?report=u7t18

Most likely you have an old version of guru program that does not support JSON output. MELPA snapshot version of the go-guru.el is guaranteed to work only with the latest version of guru. Try running go get -u golang.org/x/tools/cmd/guru (note -u flag).

@dominikh
Copy link
Member

No response in a few months, and go-guru.el no longer lives in x/tools but in https://github.com/dominikh/go-mode.el instead. This issue can be closed.

@golang golang locked and limited conversation to collaborators Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@dominikh @samv @ianlancetaylor @kostya-sh @alandonovan @gopherbot