cmd/cover: when a panic occurs in a function call, cover still marks the whole basic block covered #16325

wadey · 2016-07-11T21:52:13Z

go version go1.6.2 darwin/amd64
This is similar to #10185, but the issue still occurs if the panic happens inside of a function call.

A contrived example:

rand.go:

package covertest

import (
    "log"
    "math/rand"
)

func Rand(i int64) int64 {
    v := rand.Int63n(i)
    log.Println(v)
    return v
}

func MaybeRand(i int64) int64 {
    defer func() {
        recover()
    }()
    return Rand(i)
}

rand_test.go:

package covertest

import "testing"

func TestMaybeRand(t *testing.T) {
    if MaybeRand(0) != 0 {
        t.Error("expected zero")
    }
}

Coverage should be less than 100% because the log.Println inside of Rand is never called. But executing the tests with coverage shows:

coverage: 100.0% of statements

The issue is that the coverage blocks are not fine grained enough if a panic occurs in a function call.

The text was updated successfully, but these errors were encountered:

robpike · 2016-07-11T22:00:27Z

This is a reasonable request but is impractical to fix given the way the cover tool works. It works line-by-line, file-by-file. To solve it would require a much more global analysis of the program or be much more expensive. In your example it would either need to examine the rand package to see that Int63 can panic, or put a counter on every line, which could be too expensive in time and memory (and would require a major redesign).

robpike closed this as completed Jul 11, 2016

golang locked and limited conversation to collaborators Jul 11, 2017

gopherbot added the FrozenDueToAge label Jul 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/cover: when a panic occurs in a function call, cover still marks the whole basic block covered #16325

cmd/cover: when a panic occurs in a function call, cover still marks the whole basic block covered #16325

wadey commented Jul 11, 2016

robpike commented Jul 11, 2016

cmd/cover: when a panic occurs in a function call, cover still marks the whole basic block covered #16325

cmd/cover: when a panic occurs in a function call, cover still marks the whole basic block covered #16325

Comments

wadey commented Jul 11, 2016

robpike commented Jul 11, 2016