Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: low_resolution_timer warning #16247

Closed
benburkert opened this issue Jul 1, 2016 · 9 comments
Closed

cmd/trace: low_resolution_timer warning #16247

benburkert opened this issue Jul 1, 2016 · 9 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Go1.8

Comments

@benburkert
Copy link
Contributor

Please answer these questions before submitting your issue. Thanks!

  1. What version of Go are you using (go version)?

go version go1.7beta2 darwin/amd64

  1. What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/benburkert"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7beta2/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7beta2/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jl/n78jzg3j6nb8nzbn1vvpg9xc0000gn/T/go-build951352621=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
  1. What did you do?

build ./fibtrace from https://play.golang.org/p/tWpeEL4jse

$ go build -o fibtrace fibtrace.go
$ ./fibtrace
$ go tool trace .fibtrace fib.trace

Then browse to the "View trace" page (/trace).

  1. What did you expect to see?

The trace viewer displayed without a warning.

  1. What did you see instead?

The trace viewer with a Import Warning: low_resolution_timer: Trace time is low resolution, trace may be unusable. warning.

trace-warning
@ianlancetaylor
Copy link
Contributor

CC @dvyukov

@ianlancetaylor ianlancetaylor added this to the Go1.8 milestone Jul 1, 2016
@dvyukov
Copy link
Member

dvyukov commented Jul 1, 2016

It's not harmful. Just ignore it.
If somebody enjoys Javascript, he can dive into layers and layers of Javascript abstractions in Catapult and fix it.

@benburkert
Copy link
Contributor Author

ok, thanks @dvyukov.

@bradfitz
Copy link
Contributor

I'm going to reopen this bug. I spent time trying to find a machine with good enough timers to make that go away, but apparently the warning is always there?

This is not a good user experience.

@bradfitz bradfitz reopened this Jul 19, 2016
@ianlancetaylor
Copy link
Contributor

The warning has supposedly been removed from new versions of chrome, as of June.

https://codereview.chromium.org/2016863004

@cespare
Copy link
Contributor

cespare commented Jul 19, 2016

@ianlancetaylor so perhaps we simply need to re-copy the upstream sources? (The trace viewer bundled with the go tool is separate from that built into Chrome.)

@ianlancetaylor
Copy link
Contributor

Oh, I didn't realize we had our own copy of the HTML. I guess we could make a new copy, or just clobber the warning message in misc/trace/trace_viewer_lean.html. It's easy to find by searching for "Trace time is low resolution" in that file.

@gopherbot
Copy link

CL https://golang.org/cl/25117 mentions this issue.

gopherbot pushed a commit that referenced this issue Jul 21, 2016
@bradfitz
misc/trace: disable trace resolution warning
243d51f 
It was removed in upstream Chrome https://codereview.chromium.org/2016863004

Rather than update to the latest version, make the minimal change for Go 1.7 and
change the "showToUser" boolean from true to false.

Tested by hand that it goes away after this change.

Updates #16247

Change-Id: I051f49da878e554b1a34a88e9abc70ab50e18780
Reviewed-on: https://go-review.googlesource.com/25117
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 6, 2016
@rsc
Copy link
Contributor

rsc commented Oct 25, 2016

Not sure why this is still open. We decided the warning was not real, and it's been removed. Closing. /cc @bradfitz

@rsc rsc closed this as completed Oct 25, 2016
@golang golang locked and limited conversation to collaborators Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
8 participants
@benburkert @bradfitz @rsc @quentinmit @cespare @dvyukov @ianlancetaylor @gopherbot