Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: simplify "versioning" of binary export data (cleanup) #16244

Closed
griesemer opened this issue Jul 1, 2016 · 1 comment
Closed

cmd/compile: simplify "versioning" of binary export data (cleanup) #16244

griesemer opened this issue Jul 1, 2016 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.8

Comments

@griesemer
Copy link
Contributor

The binary exporter uses a couple of ad-hoc flags and a version string to identify details of the encoding. Make this more systematic so it's easy to add additional flags w/o having to mess with the overall format and w/o invalidating installed packages unnecessarily.
@griesemer griesemer added this to the Go1.8 milestone Jul 1, 2016
@griesemer griesemer self-assigned this Jul 1, 2016
gopherbot pushed a commit that referenced this issue Aug 17, 2016
@griesemer
cmd/compile: remove conditional code dealing with two export formats
074d6a6 
This removes some scaffolding introduced pre-1.7, introduced to
fix an export format bug, and to minimize conflicts with older
formats. The currently deployed and recognized format is "v1",
so don't worry about other versions. This is a step towards a
better scheme for internal export format versioning.

For #16244.

Change-Id: Ic7cf99dd2a24ad5484cc54aed44fa09332c2cf72
Reviewed-on: https://go-review.googlesource.com/27205
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
@griesemer griesemer mentioned this issue Aug 17, 2016
Closed
@gopherbot
Copy link

CL https://golang.org/cl/27452 mentions this issue.

@golang golang locked and limited conversation to collaborators Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
2 participants
@griesemer @gopherbot